Remove go-kit/kit/log & go-kit/log
#150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
==========================================
- Coverage 89.67% 89.42% -0.25%
==========================================
Files 35 35
Lines 1230 1220 -10
==========================================
- Hits 1103 1091 -12
- Misses 110 113 +3
+ Partials 17 16 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
denopink
added
the
webpa-common archival/deprecation
denopink
changed the title
go-kit/kit & go-kit/loggo-kit/kit/log & go-kit/log
1 task
johnabass
reviewed
Oct 26, 2022
| parseURL ParseURL | ||
| onErrorResponse OnErrorResponse | ||
| onErrorHTTPResponse OnErrorHTTPResponse | ||
| } | ||
|
|
||
| func (c *constructor) authenticationOutput(logger log.Logger, request *http.Request) (bascule.Authentication, ErrorResponseReason, error) { | ||
| func (c *constructor) authenticationOutput(logger *zap.Logger, request *http.Request) (bascule.Authentication, ErrorResponseReason, error) { |
There was a problem hiding this comment.
We should refactor this. bascule shouldn't have a direct, compile-time dependency on any logging package. Instead, it should allow application code to supply closures or observers for authentication events.
johnabass
reviewed
Oct 26, 2022
johnabass
approved these changes
Nov 7, 2022
3 tasks
|
Kudos, SonarCloud Quality Gate passed! |
denopink
deleted the
denopink/refactoring/remove-webpa-common/logging
branch
denopink
added a commit
that referenced
this pull request
Nov 30, 2022
…bpa-common/logging Remove `go-kit/kit/log` & `go-kit/log` @johnabass @renaz6 same pr as #150 no need to re-review. merging since changes have been already approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included:
go-kit/kit/log&go-kit/log#148closes #149
closes #148
closes #103