Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct return codes and eliminiate silent failure #29

Merged

Conversation

schmidtw
Copy link
Member

No description provided.

…es for cjwt_decode(). Additionally identify and error on an unsupported algorithm instead of assigning the value to be none. For existing consumers the functionality is the same if they discarded and ignored the alg=none. If consumers assumed this would result in an error, then the behavior is aligned to that expectation.
@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #29 into master will increase coverage by 0.45%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   75.11%   75.56%   +0.45%     
==========================================
  Files           2        2              
  Lines         442      442              
==========================================
+ Hits          332      334       +2     
+ Misses        110      108       -2
Flag Coverage Δ
#unittests 75.56% <84.61%> (+0.45%) ⬆️
Impacted Files Coverage Δ
tests/test_cjwt.c 81.48% <66.66%> (ø) ⬆️
src/cjwt.c 74.23% <90%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c68ceb4...ec13808. Read the comment docs.

@bill1600
Copy link
Collaborator

I see we are not accepting algorithm none.
In that case, this looks good to mw

@shilpa24balaji shilpa24balaji merged commit 9304d3e into master Nov 25, 2019
@schmidtw schmidtw deleted the correct-return-codes-and-eliminiate-silent-failure branch May 21, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants