Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for 503 #247

Merged
merged 3 commits into from
Oct 8, 2018
Merged

Conversation

bill1600
Copy link
Collaborator

@bill1600 bill1600 commented Oct 8, 2018

Change connection logic so that after an error that is not 403 or 3xx (redirect), we retry find_servers.
Also add unit test for this (code 503).

@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #247 into master will increase coverage by 0.07%.
The diff coverage is 97.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
+ Coverage   88.84%   88.91%   +0.07%     
==========================================
  Files          50       50              
  Lines        8615     8646      +31     
  Branches      673      673              
==========================================
+ Hits         7654     7688      +34     
+ Misses        316      314       -2     
+ Partials      645      644       -1
Impacted Files Coverage Δ
tests/test_connection.c 99.68% <100%> (+0.01%) ⬆️
src/connection.c 76.72% <50%> (+0.64%) ⬆️
tests/test_service_alive.c 84% <0%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd1d1ba...b4a8d8b. Read the comment docs.

@shilpa24balaji
Copy link
Collaborator

@bill1600 Please update the CHANGE log

Copy link
Collaborator

@shilpa24balaji shilpa24balaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGE log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants