Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and updated imports #103

Merged
merged 6 commits into from Aug 1, 2019
Merged

Added and updated imports #103

merged 6 commits into from Aug 1, 2019

Conversation

kristinapathak
Copy link
Contributor

  • Removed registerer code from svalinn
  • Instead, imported from wrp-listener repo
  • imported bascule for acquiring auth for registering and checking
    incoming http requests for authentication.

- Removed registerer code from svalinn
- Instead, imported from wrp-listener repo
- imported bascule for acquiring auth for registering and checking
  incoming http requests for authentication.
@kristinapathak kristinapathak added the enhancement New feature or request label Jul 24, 2019
@kristinapathak kristinapathak added this to In progress in Codex via automation Jul 24, 2019
@codecov-io
Copy link

codecov-io commented Jul 24, 2019

Codecov Report

Merging #103 into master will decrease coverage by 8.65%.
The diff coverage is 15.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   56.64%   47.98%   -8.66%     
==========================================
  Files          10        6       -4     
  Lines         459      373      -86     
==========================================
- Hits          260      179      -81     
+ Misses        190      189       -1     
+ Partials        9        5       -4
Impacted Files Coverage Δ
primaryHandler.go 80% <ø> (+1.05%) ⬆️
main.go 0% <0%> (ø) ⬆️
acquirer.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5be7af...c6b58f9. Read the comment docs.

Codex automation moved this from In progress to Reviewer approved Jul 29, 2019
@kristinapathak kristinapathak merged commit 96ab019 into master Aug 1, 2019
Codex automation moved this from Reviewer approved to Done Aug 1, 2019
@kristinapathak kristinapathak deleted the registerer branch August 1, 2019 23:14
@kristinapathak kristinapathak mentioned this pull request Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Codex
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants