WRP source #144
Merged
WRP source #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe94
reviewed
Feb 12, 2020
translation/service_test.go
Outdated
| @@ -24,7 +24,7 @@ func TestSendWRP(t *testing.T) { | |||
|
|
|||
| var expected = wrp.MustEncode(wrp.Message{ | |||
| Type: wrp.SimpleRequestResponseMessageType, | |||
| Source: "local/test", | |||
| Source: "local", | |||
There was a problem hiding this comment.
can we change this to dns:localhost to make it a bit more realistic example/test? You might have to update some other part of the tests
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
- Coverage 79.5% 79.45% -0.06%
==========================================
Files 11 11
Lines 405 404 -1
==========================================
- Hits 322 321 -1
Misses 82 82
Partials 1 1
Continue to review full report at Codecov.
|
schmidtw
approved these changes
Feb 13, 2020
kristinapathak
suggested changes
Feb 13, 2020
CHANGELOG.md
Outdated
| @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) | |||
| and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [Unreleased] | |||
| - moving partnerIDs to tr1d1um | |||
There was a problem hiding this comment.
This is part of the v0.2.1 release (below), so shouldn't be here anymore.
kristinapathak
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
[https://github.com//issues/142]