Node#content= encoding #46

Merged
merged 1 commit into from Dec 12, 2012

Conversation

Projects
None yet
3 participants
Contributor

nikitug commented Aug 25, 2012

// XXX docs indicate need for escaping entites, need to be done? danj fixed.

Before:

node.content = "unescaped & string"
node.content #=> "unescaped "

After:

node.content = "unescaped & string"
node.content #=> "unescaped & string"
node.to_s #=> "<node>unescaped &amp; string</node>"
Owner

cfis commented Sep 18, 2012

Thanks for the patch. And sorry for the delay on this. I'll try to review this and merge in your patch this weekend.

vsespb referenced this pull request Sep 18, 2012

Closed

Ampersand not escaped #48

Contributor

nikitug commented Oct 4, 2012

Hi. Any updates on this? 🍺 :bowtie:

shtirlic commented Nov 9, 2012

👍

@cfis cfis added a commit that referenced this pull request Dec 12, 2012

@cfis cfis Merge pull request #46 from nikitug/node_content_encoding
Node#content= encoding
d381ef7

@cfis cfis merged commit d381ef7 into xml4r:master Dec 12, 2012

Owner

cfis commented Dec 12, 2012

Thanks - patch looks good and applied!

Contributor

nikitug commented Dec 12, 2012

🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment