Skip to content

Conversation

@ffgan
Copy link
Contributor

@ffgan ffgan commented Oct 15, 2025

PyPI recently added support for riscv64(rv64) wheel packages, so we can consider adding rv64 support for python-xmlsec.

Below are the CI results:
Wheel build

The results are generally well presented.


Other Info
Co-authored by: nijincheng@iscas.ac.cn;

ffgan and others added 3 commits October 15, 2025 21:09
Co-authored by: nijincheng@iscas.ac.cn;
Co-authored by: nijincheng@iscas.ac.cn;
@mxamin mxamin requested a review from Copilot October 15, 2025 15:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for building riscv64 wheels for python-xmlsec. PyPI has recently added support for riscv64 wheel packages, and this change enables the project to build and distribute wheels for this architecture.

  • Adds riscv64 to the list of supported architectures in the cibuildwheel configuration
  • Implements a workaround for an OpenSSL assembly code issue on riscv64 by adding the no-asm flag
  • Updates dependency versions (cibuildwheel, ruff, setuptools, lxml) to support the new build requirements

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
setup.py Adds riscv64-specific OpenSSL build configuration with no-asm flag to work around assembly code relocation issues; moves import statement
pyproject.toml Adds riscv64 to supported Linux architectures, pins setuptools and lxml versions, skips musllinux_riscv64 builds, adds setuptools_scm configuration
.github/workflows/wheels.yml Updates cibuildwheel version from 2.21.3 to 3.1.4
requirements-test.txt Updates ruff version from 0.12.3 to 0.13.0
doc/source/requirements.txt Pins lxml version to 6.0.2

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ffgan
Copy link
Contributor Author

ffgan commented Oct 16, 2025

The CI failure is a network issue; just retry it. This problem might occur a bit frequently here. Perhaps we could consider putting these required dependencies in a separate repository and pulling from that repository when needed. This way we can avoid network issues caused by accessing other websites.

@mxamin
Copy link
Collaborator

mxamin commented Oct 16, 2025

The CI failure is a network issue; just retry it. This problem might occur a bit frequently here. Perhaps we could consider putting these required dependencies in a separate repository and pulling from that repository when needed. This way we can avoid network issues caused by accessing other websites.

You're right, the failure is because of a network issue. I'm planning to fix the dependencies to a specific version and put them all in a separate repository as we did for Windows builds before releasing the next version.

@mxamin mxamin merged commit a241c56 into xmlsec:master Oct 16, 2025
1 check passed
@ffgan
Copy link
Contributor Author

ffgan commented Oct 29, 2025

Hello maintainer @mxamin , could you please consider releasing a new version to provide available rv64 wheels on PyPI?

@mxamin
Copy link
Collaborator

mxamin commented Oct 29, 2025

@ffgan Sure! I was planning to do that soon. Probably next week, or maybe earlier if I find some spare time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants