New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeFilter should apply to more nodes #116

Closed
bodewig opened this Issue Apr 11, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@bodewig
Member

bodewig commented Apr 11, 2018

Currently NodeFilter is not applied to DocumentType so you cannot suppress the comparisons. There may be even more Nodes missing, a cursory look through DOMDifferenceEngine says it probably is the only one but a second pair of eyes won't hurt. I don't think there is any good reason to apply it to Document itself as this would simply skip all comparisons altogether.

See also xmlunit/xmlunit.net#26 which may provide a solution that "just" need to get ported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment