New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AssertJ #117

Closed
krystiankaluzny opened this Issue Apr 11, 2018 · 8 comments

Comments

Projects
None yet
3 participants
@krystiankaluzny
Member

krystiankaluzny commented Apr 11, 2018

First of all, thanks for XMLUnit, it's great tool.
I use AssertJ as assertions tool for java and I have to copy implementation of HasXPathMatcher.match() to my code, write some assertj specific helper clesses and finally write tests.

Are there any plans for supporting AssertJ?

@bodewig

This comment has been minimized.

Show comment
Hide comment
@bodewig

bodewig Apr 11, 2018

Member

I'm not an AssertJ user myself, but would accept pull requests for a new module that adds AssertJ assertions, if anybody provided them ;-)

Member

bodewig commented Apr 11, 2018

I'm not an AssertJ user myself, but would accept pull requests for a new module that adds AssertJ assertions, if anybody provided them ;-)

@krystiankaluzny

This comment has been minimized.

Show comment
Hide comment
@krystiankaluzny

krystiankaluzny Apr 12, 2018

Member

I was expecting that :) Maybe soon I will find the time to code something

Member

krystiankaluzny commented Apr 12, 2018

I was expecting that :) Maybe soon I will find the time to code something

@bodewig

This comment has been minimized.

Show comment
Hide comment
@bodewig

bodewig Apr 13, 2018

Member

That would be great, thank you.

Member

bodewig commented Apr 13, 2018

That would be great, thank you.

@bbottema

This comment has been minimized.

Show comment
Hide comment
@bbottema

bbottema commented May 11, 2018

@krystiankaluzny, @bodewig, any progress here?

@bodewig

This comment has been minimized.

Show comment
Hide comment
@bodewig

bodewig May 13, 2018

Member

@krystiankaluzny has opened #120 which starts with XPath support,

Member

bodewig commented May 13, 2018

@krystiankaluzny has opened #120 which starts with XPath support,

@bodewig bodewig added this to the 2.6.1 milestone May 14, 2018

bodewig added a commit that referenced this issue May 14, 2018

@bodewig

This comment has been minimized.

Show comment
Hide comment
@bodewig

bodewig Jun 28, 2018

Member

see also #126 for the next step - great work @krystiankaluzny !

Member

bodewig commented Jun 28, 2018

see also #126 for the next step - great work @krystiankaluzny !

@bodewig

This comment has been minimized.

Show comment
Hide comment
@bodewig

bodewig Jul 30, 2018

Member

see also #129 - after which I think we can close this issue.

Member

bodewig commented Jul 30, 2018

see also #129 - after which I think we can close this issue.

@krystiankaluzny

This comment has been minimized.

Show comment
Hide comment
@krystiankaluzny

krystiankaluzny Aug 15, 2018

Member

User guide pages about xmlunit-assertj module:
Comparing XML
Selecting Nodes with XPath
Evaluating XPath

Member

krystiankaluzny commented Aug 15, 2018

User guide pages about xmlunit-assertj module:
Comparing XML
Selecting Nodes with XPath
Evaluating XPath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment