Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement isNumber placeholder #153

Closed
NathanAtClarity opened this issue May 31, 2019 · 3 comments

Comments

@NathanAtClarity
Copy link
Contributor

commented May 31, 2019

The page about placeholders on the wiki (https://github.com/xmlunit/user-guide/wiki/Placeholders) describes an example placeholder isNumber

The implementation of this placeholder should:

  • work on attribute and element values (in the same way that ignore does)
  • allow the diff engine to identify differences if the attribute or element value cannot be parsed as a number
  • acceptable numbers include positive and negative integers, positive and negative floating point numbers, and positive and negative floating point numbers in engineering notation
@NathanAtClarity

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

I have already written some code that provisionally supports the above (to support another project that uses xmlunit) so I would be happy to productionize my code and submit it as a PR

@bodewig

This comment has been minimized.

Copy link
Member

commented May 31, 2019

A PR would be wonderful, thank you.

@bodewig

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

fixed via #154

@bodewig bodewig closed this Jun 2, 2019

bodewig added a commit that referenced this issue Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.