New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements of assertj module #126

Merged
merged 14 commits into from Jun 29, 2018

Conversation

Projects
None yet
3 participants
@krystiankaluzny
Member

krystiankaluzny commented Jun 27, 2018

Following features were add to assertj module:

  • check validation API, equivalent of ValidationMatcher
  • check value of XPath expresion API, equivalent of EvaluateXPathMatcher
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 28, 2018

Coverage Status

Coverage increased (+0.2%) to 91.96% when pulling 6b77198 on krystiankaluzny:master into 23336de on xmlunit:master.

coveralls commented Jun 28, 2018

Coverage Status

Coverage increased (+0.2%) to 91.96% when pulling 6b77198 on krystiankaluzny:master into 23336de on xmlunit:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 28, 2018

Coverage Status

Coverage increased (+0.02%) to 91.754% when pulling 372d0ca on krystiankaluzny:master into 23336de on xmlunit:master.

coveralls commented Jun 28, 2018

Coverage Status

Coverage increased (+0.02%) to 91.754% when pulling 372d0ca on krystiankaluzny:master into 23336de on xmlunit:master.

@krystiankaluzny

This comment has been minimized.

Show comment
Hide comment
@krystiankaluzny

krystiankaluzny Jun 28, 2018

Member

I also plan to add compare API (equivalent of CompareMatcher) and after that write something in the user guide.

BTW. Now, maven have problem with TLS in java6 build mode. Downloading artifacts failed with message: Received fatal alert: protocol_version.

Edit: Probably it's related to issue travis-ci/travis-ci#9713

Member

krystiankaluzny commented Jun 28, 2018

I also plan to add compare API (equivalent of CompareMatcher) and after that write something in the user guide.

BTW. Now, maven have problem with TLS in java6 build mode. Downloading artifacts failed with message: Received fatal alert: protocol_version.

Edit: Probably it's related to issue travis-ci/travis-ci#9713

@bodewig

This comment has been minimized.

Show comment
Hide comment
@bodewig

bodewig Jun 28, 2018

Member

I've seen the Java6 failures in other builds of mine before, the TLS stack in Java6 is pretty old and doesn't cope with longer keys or "more modern" ciphers (I think it doesn't even support Diffie-Hellman properly). Most likely Maven central has enabled a TLS feature that Java6 lacks. I'll look into it separately.

Many, many thanks!

Member

bodewig commented Jun 28, 2018

I've seen the Java6 failures in other builds of mine before, the TLS stack in Java6 is pretty old and doesn't cope with longer keys or "more modern" ciphers (I think it doesn't even support Diffie-Hellman properly). Most likely Maven central has enabled a TLS feature that Java6 lacks. I'll look into it separately.

Many, many thanks!

@bodewig bodewig referenced this pull request Jun 28, 2018

Closed

Support AssertJ #117

@bodewig bodewig merged commit 7ef7815 into xmlunit:master Jun 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 91.96%
Details
@bodewig

This comment has been minimized.

Show comment
Hide comment
@bodewig

bodewig Jun 29, 2018

Member

Thanks a lot!

Member

bodewig commented Jun 29, 2018

Thanks a lot!

bodewig added a commit that referenced this pull request Jun 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment