s4/tests: fix build failure against gcc-10 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On gcc-10 (and gcc-9 -fno-common) build fails as: ``` ld: tests/s4/t_transactions.c.2.o:/tests/s4/t_transactions.c:22: multiple definition of `s4'; tests/s4/t_s4.c.2.o:tests/s4/t_s4.c:31: first defined here collect2: error: ld returned 1 exit status Waf: Leaving directory `/home/slyfox/dev/git/s4/_build_' Build failed -> task in 'test_s4' failed (exit status 1): ``` gcc-10 will change the default from -fcommon to fno-common: https://gcc.gnu.org/PR85678. The error also happens if CFLAGS=-fno-common passed explicitly. Reported-by: Toralf Förster Bug: https://bugs.gentoo.org/706940 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
|
amazeballs! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On gcc-10 (and gcc-9 -fno-common) build fails as:
gcc-10 will change the default from -fcommon to fno-common:
https://gcc.gnu.org/PR85678.
The error also happens if CFLAGS=-fno-common passed explicitly.
Reported-by: Toralf Förster
Bug: https://bugs.gentoo.org/706940