GridSelect: border colour and vertically centring text #151
Conversation
|
@samdoshi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aavogt, @clefru and @asgaroth89 to be potential reviewers. |
|
LGTM |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
2 small changes to
XMonad.Actions.GridSelect:Allow border colour to be specified
This required an extra field on
GSConfigso it is a breaking change.Improve the vertical centring of text
(I cut and pasted the code from
XMonad.Utils.Prompt.)Before:
After:
Checklist
I've read CONTRIBUTING.md
I tested my changes with xmonad-testing
I updated the
CHANGES.mdfile