krunner and kickoff windows disappear after first run

[gbrsales]

Problem Description

I'm using xmonad in the KDE Plasma Desktop environment. When I hit the Alt+F2 combination, the krunner launcher should start and wait for some input. This works the first time I run it, but on subsequent invocations no window appears.

Kickoff (the start menu) exhibits a similar behavior. The first time I click its button in the task bar, the menu pops up. From that point on, other clicks do not produce any visible result other than a quick flash (possibly the menu appearing and immediately disappearing).

I found in the .xsession-errors log file multiple messages like the following:

Bad _NET_DESKTOP with data[0]=-1

Tested on a fresh install of Fedora 28 (KDE Plasma Desktop spin).

Xmonad version: 0.13
KDE Plasma version: 5.12.6
KDE Frameworks version: 5.47.0
QT version: 5.10.1
Kernel version: 4.17.3 (64bit)

The configuration below used to work on Fedora 27.

Configuration File

import           XMonad
import           XMonad.Config.Kde
import           XMonad.Hooks.ManageDocks

myManageHook = composeAll
  [ className =? "plasmashell"  --> doFloat ]

main = xmonad $ docks kde4Config
         { terminal   = "konsole"
	 , workspaces = ["1","2","3","4","5","6"]
         , modMask    = mod4Mask
	 , manageHook = myManageHook <+> (manageHook kde4Config)
	 , layoutHook = avoidStruts (layoutHook kde4Config) }

[billksun]

So in my experience, if you keep pressing Alt+F2 repeatedly (or just hold the buttons), eventually you'll start to see krunner flashing at the top of the screen. If you stop and then press Alt+F2 once, you'll have a much better chance of having krunner stick.

It seems like the krunner window is having a hard time keeping the focus. In the instances where it doesn't show up, pressing the hotkey will result in the border of the currently focused window flashing once.

BTW, it looks like avoidStruts here in your configuration is redundant as that is already used in desktopLayoutModifiers which is referenced in desktopConfig, which is then referenced by kde4Config.

[billksun]

Here's another discovery:

If you use className =? "krunner" -?> doIgnore, then krunner will always show up! But the problem with that is the krunner box will not receive focus or be selected by XMonad as you cannot type in the searchbox, even if you mouse click into it.

[cpp-10]

I believe this is a regression in Plasma Framework 5.47.0 (on my configuration, KDE dialogs disappearing did not happen prior to this version). Reverting the commit introduced by KDE bugfix 381242 seems to fix the issue.

I have cut a bug to KDE to see if they can fix it: https://bugs.kde.org/show_bug.cgi?id=396177 .

[kaethorn]

This issue makes using XMonad on KDE almost pointless. A workaround on Gentoo for all who don't care about bugfix 381242 is to drop the following in /etc/portage/patches/kde-frameworks/plasma/xmonad-regression-from-bug-381242.patch:

diff --git a/src/plasmaquick/dialog.cpp b/src/plasmaquick/dialog.cpp
index fe5d9b2..2fc267b 100644
--- a/src/plasmaquick/dialog.cpp
+++ b/src/plasmaquick/dialog.cpp
@@ -737,14 +737,6 @@ Dialog::Dialog(QQuickItem *parent)
     connect(this, &QWindow::xChanged, [=]() { d->slotWindowPositionChanged(); });
     connect(this, &QWindow::yChanged, [=]() { d->slotWindowPositionChanged(); });
 
-    // Given dialogs are skip task bar and don't have a decoration
-    // minimizing them using e.g. "minimize all" should just close them
-    connect(this, &QWindow::windowStateChanged, this, [this](Qt::WindowState newState) {
-        if (newState == Qt::WindowMinimized) {
-            setVisible(false);
-        }
-    });
-
     connect(this, SIGNAL(visibleChanged(bool)),
             this, SIGNAL(visibleChangedProxy()));
     connect(this, SIGNAL(visibleChanged(bool)),
@@ -1365,11 +1357,6 @@ void Dialog::setVisible(bool visible)
         if (visible && d->mainItem) {
             d->mainItem->setVisible(true);
         }
-
-#if QT_VERSION >= QT_VERSION_CHECK(5, 10, 0)
-        // Bug 381242: Qt remembers minimize state and re-applies it when showing
-        setWindowStates(windowStates() & ~Qt::WindowMinimized);
-#endif
         QQuickWindow::setVisible(visible);
         //signal will be emitted and proxied from the QQuickWindow code
     } else {

Afterwards, just re-emerge kde-frameworks/plasma.

[achea]

The above patch doesn't apply for plasma-5.57 anymore so here is an update (that works for me):

diff --git a/src/plasmaquick/dialog.cpp b/src/plasmaquick/dialog.cpp
index c9f9cd87d..4fcf4faab 100644
--- a/src/plasmaquick/dialog.cpp
+++ b/src/plasmaquick/dialog.cpp
@@ -733,14 +733,6 @@ Dialog::Dialog(QQuickItem *parent)
     connect(this, &QWindow::xChanged, [=]() { d->slotWindowPositionChanged(); });
     connect(this, &QWindow::yChanged, [=]() { d->slotWindowPositionChanged(); });
 
-    // Given dialogs are skip task bar and don't have a decoration
-    // minimizing them using e.g. "minimize all" should just close them
-    connect(this, &QWindow::windowStateChanged, this, [this](Qt::WindowState newState) {
-        if (newState == Qt::WindowMinimized) {
-            setVisible(false);
-        }
-    });
-
     connect(this, SIGNAL(visibleChanged(bool)),
             this, SIGNAL(visibleChangedProxy()));
     connect(this, SIGNAL(visibleChanged(bool)),
@@ -1356,8 +1348,6 @@ void Dialog::setVisible(bool visible)
             setPosition(popupPosition(d->visualParent, size()));
         }
 
-        // Bug 381242: Qt remembers minimize state and re-applies it when showing
-        setWindowStates(windowStates() & ~Qt::WindowMinimized);
         QQuickWindow::setVisible(visible);
         //signal will be emitted and proxied from the QQuickWindow code
     } else {

[gwwatkin]

Using , className =? "krunner" --> doIgnore >> doFloat, in the manage hooks, makes krunner stay in every circumstance, except for when you use it imediately after switch Xinerama monitor. Then it outputs the usual Bad _NET_DESKTOP with data[0]=-1, and if you alt+F2 again, it stays, but in old monitor.

Not sure why this works but it's a woraround that makes krunner usable.

I was also having problems with trays such as system, network and volume. Using the ManageHook isKDETrayWindow --> doIgnore >> doFloat fixed them for all the usages I could think of.

[gwwatkin]

If you change monitor by clicking into a window then krunner always stays

[AlecsFerra]

So this is KDE bug? Has anyone opened an issue about this?

[bsloane1650]

The latest patch does not resolve the issue for me (plasma 5.68.0). The below works for me:

diff --git a/src/plasmaquick/dialog.cpp b/src/plasmaquick/dialog.cpp
index cc4863a2d..472163451 100644
--- a/src/plasmaquick/dialog.cpp
+++ b/src/plasmaquick/dialog.cpp
@@ -803,6 +803,8 @@ Dialog::Dialog(QQuickItem *parent)
     connect(this, &QWindow::xChanged, [=]() { d->slotWindowPositionChanged(); });
     connect(this, &QWindow::yChanged, [=]() { d->slotWindowPositionChanged(); });
 
+//https://github.com/xmonad/xmonad/issues/174#issuecomment-406886552
+/*
     // Given dialogs are skip task bar and don't have a decoration
     // minimizing them using e.g. "minimize all" should just close them
     connect(this, &QWindow::windowStateChanged, this, [this](Qt::WindowState newState) {
@@ -810,6 +812,7 @@ Dialog::Dialog(QQuickItem *parent)
             setVisible(false);
         }
     });
+*/
 
     connect(this, &QWindow::visibleChanged,
             this, &Dialog::visibleChangedProxy);
@@ -1182,7 +1185,8 @@ void Dialog::focusOutEvent(QFocusEvent *ev)
         const bool viewClicked = qobject_cast<const KQuickAddons::QuickViewSharedEngine *>(focusWindow) || qobject_cast<const View *>(focusWindow) || qobject_cast<const ConfigView *>(focusWindow);
 
         if (viewClicked || (!parentHasFocus && !childHasFocus)) {
-            setVisible(false);
+            //https://github.com/xmonad/xmonad/issues/174#issuecomment-406886552
+            //setVisible(false);
             emit windowDeactivated();
         }
     }
@@ -1417,8 +1421,11 @@ void Dialog::setVisible(bool visible)
             setPosition(popupPosition(d->visualParent, size()));
         }
 
+//https://github.com/xmonad/xmonad/issues/174#issuecomment-406886552
+/*
         // Bug 381242: Qt remembers minimize state and re-applies it when showing
         setWindowStates(windowStates() & ~Qt::WindowMinimized);
+*/
         QQuickWindow::setVisible(visible);
         //signal will be emitted and proxied from the QQuickWindow code
     } else {

This includes the fixes suggested previously, which appear to still be necessary. This fix does have the side effect of not closing the widgets when they lose focus.

[billksun]

So this is KDE bug? Has anyone opened an issue about this?

https://bugs.kde.org/show_bug.cgi?id=396177

[hashborgir]

For KDE Plasma Latest on Ubuntu 22.04

I don't want to post patches, as I've seen two patches posted here which simply will not work for any other version where the code has been changed or updated.

I will provide with what works for me on 22.04 Kubuntu and pool/universe/p/plasma-framework/plasma-framework_5.92.0-0ubuntu1_amd64.deb

Instructions for K/Ubuntu 22.04

First we build depends for plasma-framework package so we can build the package

1. apt-get build-dep plasma-framework

Then we get the package source

2. sudo apt-get source plasma-framework

Then we edit plasma-framework-5.92.0/src/plasmaquick/dialog.cpp

Function (for 5.92) is located at line # 828 (do Ctrl + F for Dialog::Dialog(QQuickItem *parent))
Compare with https://github.com/KDE/plasma-framework/blob/master/src/plasmaquick/dialog.cpp#L828

Dialog::Dialog(QQuickItem *parent)
    : QQuickWindow(parent ? parent->window() : nullptr)
    , d(new DialogPrivate(this))
{
    setColor(QColor(Qt::transparent));
    setFlags(Qt::FramelessWindowHint | Qt::Dialog);

    connect(this, &QWindow::xChanged, [=]() {
        d->slotWindowPositionChanged();
    });
    connect(this, &QWindow::yChanged, [=]() {
        d->slotWindowPositionChanged();
    });

    //  I COMMENTED THIS OUT
    // Given dialogs are skip task bar and don't have a decoration
    // minimizing them using e.g. "minimize all" should just close them
    //     connect(this, &QWindow::windowStateChanged, this, [this](Qt::WindowState newState) {
    //         if (newState == Qt::WindowMinimized) {
    //             setVisible(false);
    //         }
    //     });

    //     I COMMENTED THIS OUT
    //     connect(this, &QWindow::visibleChanged, this, &Dialog::visibleChangedProxy);
    //     connect(this, SIGNAL(visibleChanged(bool)), this, SLOT(updateInputShape()));
    //     connect(this, SIGNAL(outputOnlyChanged()), this, SLOT(updateInputShape()));


    // I ADDED THIS
    connect(this, SIGNAL(visibleChanged(bool)),
    this, SIGNAL(visibleChangedProxy()));
    connect(this, SIGNAL(visibleChanged(bool)),
        this, SLOT(updateInputShape()));
    connect(this, SIGNAL(outputOnlyChanged()),
        this, SLOT(updateInputShape()));    

    // HACK: this property is invoked due to the initialization that gets done to contentItem() in the getter
    property("data");
    // Create the FrameSvg background.
    d->frameSvgItem = new Plasma::FrameSvgItem(contentItem());
    // This is needed as a transition thing for KWayland
    setProperty("__plasma_frameSvg", QVariant::fromValue(d->frameSvgItem->frameSvg()));

    connect(&d->theme, SIGNAL(themeChanged()), this, SLOT(updateTheme()));
}

Now Edit the Second Function

Then at line 1452, find the function (Ctrl + F for void Dialog::setVisible(bool visible)
Make sure your function looks like this.
Compare with: https://github.com/KDE/plasma-framework/blob/master/src/plasmaquick/dialog.cpp#L1445

void Dialog::setVisible(bool visible)
{
    // only update real visibility when we have finished component completion
    // and all flags have been set

    d->visible = visible;
    if (d->componentComplete) {
        if (visible && d->visualParent) {
            setPosition(popupPosition(d->visualParent, size()));
        }

        // Bug 381242: Qt remembers minimize state and re-applies it when showing

        // I COMMENTED THIS OUT
        // setWindowStates(windowStates() & ~Qt::WindowMinimized);

        // I ADDED THIS
        if (visible && d->mainItem) {
            d->mainItem->setVisible(true);
        }
        QQuickWindow::setVisible(visible);
        // signal will be emitted and proxied from the QQuickWindow code
    } else {
        Q_EMIT visibleChangedProxy();
    }
}

If you are on any other version but 5.92, use the above method to manually make sure the code looks like this. Only have to intelligently look and change a few lines in both functions. Understand what's happening by reading the code.

5.92 Patch

If you are on 5.92 and feeling lazy, please, use the following patch:

--- dialog_orig.cpp	2022-05-04 17:12:32.993771709 -0600
+++ dialog.cpp	2022-05-04 16:49:39.917448206 -0600
@@ -475,7 +475,7 @@
 
 void DialogPrivate::updateLayoutParameters()
 {
-    if (!componentComplete || !mainItem || !mainItemLayout || q->visibility() == QWindow::Hidden) {
+    if (!componentComplete || !mainItem || !mainItemLayout) {
         return;
     }
 
@@ -579,7 +579,7 @@
 {
     Q_ASSERT(mainItem);
 
-    if (!componentComplete || q->visibility() == QWindow::Hidden) {
+    if (!componentComplete) {
         return;
     }
     if (mainItem->width() <= 0 || mainItem->height() <= 0) {
@@ -841,15 +841,22 @@
 
     // Given dialogs are skip task bar and don't have a decoration
     // minimizing them using e.g. "minimize all" should just close them
-    connect(this, &QWindow::windowStateChanged, this, [this](Qt::WindowState newState) {
-        if (newState == Qt::WindowMinimized) {
-            setVisible(false);
-        }
-    });
-
-    connect(this, &QWindow::visibleChanged, this, &Dialog::visibleChangedProxy);
-    connect(this, SIGNAL(visibleChanged(bool)), this, SLOT(updateInputShape()));
-    connect(this, SIGNAL(outputOnlyChanged()), this, SLOT(updateInputShape()));
+    //     connect(this, &QWindow::windowStateChanged, this, [this](Qt::WindowState newState) {
+    //         if (newState == Qt::WindowMinimized) {
+    //             setVisible(false);
+    //         }
+    //     });
+
+//     connect(this, &QWindow::visibleChanged, this, &Dialog::visibleChangedProxy);
+//     connect(this, SIGNAL(visibleChanged(bool)), this, SLOT(updateInputShape()));
+//     connect(this, SIGNAL(outputOnlyChanged()), this, SLOT(updateInputShape()));
+    
+    connect(this, SIGNAL(visibleChanged(bool)),
+    this, SIGNAL(visibleChangedProxy()));
+    connect(this, SIGNAL(visibleChanged(bool)),
+        this, SLOT(updateInputShape()));
+    connect(this, SIGNAL(outputOnlyChanged()),
+        this, SLOT(updateInputShape()));    
 
     // HACK: this property is invoked due to the initialization that gets done to contentItem() in the getter
     property("data");
@@ -1150,7 +1157,7 @@
     }
 
     // A dialog can be resized even if no mainItem has ever been set
-    if (!d->mainItem || !isExposed()) {
+    if (!d->mainItem) {
         return;
     }
 
@@ -1454,7 +1461,9 @@
         }
 
         // Bug 381242: Qt remembers minimize state and re-applies it when showing
-        setWindowStates(windowStates() & ~Qt::WindowMinimized);
+        if (visible && d->mainItem) {
+            d->mainItem->setVisible(true);
+        }
         QQuickWindow::setVisible(visible);
         // signal will be emitted and proxied from the QQuickWindow code
     } else {

Once both functions are edited/updated properly as above

3. apt-get -b source plasma-framework in the top level directory where you download the sources from debian/ubuntu

Then install all the resulting packages in that directory

4. sudo dpkg -i *.deb

[MuhammedZakir]

When I used to use KDE+XMonad, to show krunner properly, I ran it using some search-text. I don't remember whether I used the cli or dbus for this though.

[hashborgir]

Hello, Happy Holidays and Merry Christmas Xmonad Patch. I have a new patch for you guys for Kubuntu 22.10 KDE plasma 5.98

Follow the instructions from above on how to, then use the following patch or code.

--- dialog2.cpp	2022-12-15 00:32:56.704694080 -0700
+++ dialog.cpp	2022-12-15 00:26:17.630794349 -0700
@@ -1035,15 +1035,24 @@
 
     // Given dialogs are skip task bar and don't have a decoration
     // minimizing them using e.g. "minimize all" should just close them
-    connect(this, &QWindow::windowStateChanged, this, [this](Qt::WindowState newState) {
-        if (newState == Qt::WindowMinimized) {
-            setVisible(false);
-        }
-    });
-
-    connect(this, &QWindow::visibleChanged, this, &Dialog::visibleChangedProxy);
-    connect(this, SIGNAL(visibleChanged(bool)), this, SLOT(updateInputShape()));
-    connect(this, SIGNAL(outputOnlyChanged()), this, SLOT(updateInputShape()));
+    // connect(this, &QWindow::windowStateChanged, this, [this](Qt::WindowState newState) {
+    //     if (newState == Qt::WindowMinimized) {
+    //         setVisible(false);
+    //     }
+    // }); // block commented out by Hash Borgir for Xmonad compatibility
+
+    // connect(this, &QWindow::visibleChanged, this, &Dialog::visibleChangedProxy); // commented out by Hash Borgir for Xmonad compatibility
+    // connect(this, SIGNAL(visibleChanged(bool)), this, SLOT(updateInputShape())); // commented out by Hash Borgir for Xmonad compatibility
+    // connect(this, SIGNAL(outputOnlyChanged()), this, SLOT(updateInputShape())); // commented out by Hash Borgir for Xmonad compatibility
+
+    // Xmonad compatibility patch added by Hash Borgir -- START
+    connect(this, SIGNAL(visibleChanged(bool)),
+    this, SIGNAL(visibleChangedProxy()));
+    connect(this, SIGNAL(visibleChanged(bool)),
+        this, SLOT(updateInputShape()));
+    connect(this, SIGNAL(outputOnlyChanged()),
+        this, SLOT(updateInputShape()));
+    // Xmonad compatibility patch added by Hash Borgir -- END
 
     // HACK: this property is invoked due to the initialization that gets done to contentItem() in the getter
     property("data");
@@ -1688,7 +1697,12 @@
         }
 
         // Bug 381242: Qt remembers minimize state and re-applies it when showing
-        setWindowStates(windowStates() & ~Qt::WindowMinimized);
+        // setWindowStates(windowStates() & ~Qt::WindowMinimized); // commented out by Hash Borgir for Xmonad Compatibility
+        // if block added by Hash Borgir for Xmonad Compatibility -- START
+        if (visible && d->mainItem) {
+            d->mainItem->setVisible(true);
+        }
+        // if block added by Hash Borgir for Xmonad Compatibility -- END
         QQuickWindow::setVisible(visible);
         // signal will be emitted and proxied from the QQuickWindow code
     } else {

If you''re not able to apply the patch, for some reason, then just edit the dialog.ccp file and modify these following two functions:

Line 1019:

Dialog::Dialog(QQuickItem *parent)
    : QQuickWindow(parent ? parent->window() : nullptr)
    , d(new DialogPrivate(this))
{
    setColor(QColor(Qt::transparent));
    setFlags(Qt::FramelessWindowHint | Qt::Dialog);

    connect(this, &QWindow::xChanged, [=]() {
        d->slotWindowPositionChanged();
    });
    connect(this, &QWindow::yChanged, [=]() {
        d->slotWindowPositionChanged();
    });
    connect(this, &Dialog::locationChanged, this, [&] {
        d->updateResizableEdges();
    });

    // Given dialogs are skip task bar and don't have a decoration
    // minimizing them using e.g. "minimize all" should just close them
    // connect(this, &QWindow::windowStateChanged, this, [this](Qt::WindowState newState) {
    //     if (newState == Qt::WindowMinimized) {
    //         setVisible(false);
    //     }
    // }); // block commented out by Hash Borgir for Xmonad compatibility

    // connect(this, &QWindow::visibleChanged, this, &Dialog::visibleChangedProxy); // commented out by Hash Borgir for Xmonad compatibility
    // connect(this, SIGNAL(visibleChanged(bool)), this, SLOT(updateInputShape())); // commented out by Hash Borgir for Xmonad compatibility
    // connect(this, SIGNAL(outputOnlyChanged()), this, SLOT(updateInputShape())); // commented out by Hash Borgir for Xmonad compatibility

    // Xmonad compatibility patch added by Hash Borgir -- START
    connect(this, SIGNAL(visibleChanged(bool)),
    this, SIGNAL(visibleChangedProxy()));
    connect(this, SIGNAL(visibleChanged(bool)),
        this, SLOT(updateInputShape()));
    connect(this, SIGNAL(outputOnlyChanged()),
        this, SLOT(updateInputShape()));
    // Xmonad compatibility patch added by Hash Borgir -- END

    // HACK: this property is invoked due to the initialization that gets done to contentItem() in the getter
    property("data");
    // Create the FrameSvg background.
    d->frameSvgItem = new Plasma::FrameSvgItem(contentItem());
    // This is needed as a transition thing for KWayland
    setProperty("__plasma_frameSvg", QVariant::fromValue(d->frameSvgItem->frameSvg()));

    connect(&d->theme, SIGNAL(themeChanged()), this, SLOT(updateTheme()));
}

Line 1688:

void Dialog::setVisible(bool visible)
{
    // only update real visibility when we have finished component completion
    // and all flags have been set

    d->visible = visible;
    if (d->componentComplete) {
        if (visible && d->visualParent) {
            setPosition(popupPosition(d->visualParent, size()));
        }

        // Bug 381242: Qt remembers minimize state and re-applies it when showing
        // setWindowStates(windowStates() & ~Qt::WindowMinimized); // commented out by Hash Borgir for Xmonad Compatibility
        // if block added by Hash Borgir for Xmonad Compatibility -- START
        if (visible && d->mainItem) {
            d->mainItem->setVisible(true);
        }
        // if block added by Hash Borgir for Xmonad Compatibility -- END
        QQuickWindow::setVisible(visible);
        // signal will be emitted and proxied from the QQuickWindow code
    } else {
        Q_EMIT visibleChangedProxy();
    }
}

Enjoy fellow Xmonad KDE users! <3 :)

[hashborgir]

Someone asked about buildilng on Fedora. I've never used Fedora but I setup a VM and tested out the patch on plasma 5.101 in Fedora 37

Here are the build instructions I used in case they might help someone.

   1  dnf download --source plasma-framework
   2  rpm --install kf5-plasma-5.101.0-1.fc37.src.rpm 
   3  cd rpmbuild/SOURCES/
   4  tar xf plasma-framework-5.101.0.tar.xz 
   5  cd plasma-framework-5.101.0/src/plasmaquick/
   6  edit dialog.cpp EDIT SOURCE, apply my patch.
   
   7  dnf builddep /root/rpmbuild/SPECS/kf5-plasma.spec 
   8  rpmbuild -bb /root/rpmbuild/SPECS/kf5-plasma.spec   
   9  cd rpmbuild/RPMS/x86_64/
  
  10  dnf install *.rpm
  11  dnf install xmonad
  12  xmonad --replace &

   PANELS WORKING in KDE/xmonad in Fedora 37