Avoid segfaulting on null database entries #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
force-pushed
the
fix-segfaults
branch
2 times, most recently
from
13d2b52
to
91f74b3
Compare
|
I think I'll fix this up later today with an Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
@bb010g Hi. Is this bug fixed in 0.6.0? At least I cannot reproduce it. I am preparing a package in Gentoo, so I'm wondering if I should add this patch. |
Yes, it’s still present, but it only happens on upgrades from very old releases. I’ve updated the PR to address the comments, using the patch I applied to the latest Debian package. |
This was taken from Julien Cristau's patch in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=492414 and updated to use an atoi_or function based on review feedback. Signed-off-by: Stephen Kitt <steve@sk2.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This was taken from
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=492414
Signed-off-by: Stephen Kitt steve@sk2.org
This change is