Fix bug in Client #45

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@hpychan
Contributor

hpychan commented Nov 25, 2011

I found minor bugs that the no error event was emitted if there is error during socket.conneect.

@lloydwatkin

This comment has been minimized.

Show comment Hide comment
@lloydwatkin

lloydwatkin May 18, 2013

Owner

HI @hpychan I'm going to close it as the code around this seems to have changed significantly. If you are still facing the issue please could you create a new pull request? Thanks, Lloyd.

Owner

lloydwatkin commented May 18, 2013

HI @hpychan I'm going to close it as the code around this seems to have changed significantly. If you are still facing the issue please could you create a new pull request? Thanks, Lloyd.

sonnyp added a commit that referenced this pull request Jun 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment