Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

we really need a way to know when a C2SStream has been disconnected #46

Merged
merged 2 commits into from Nov 29, 2011

Conversation

Projects
None yet
2 participants
Contributor

julien51 commented Nov 28, 2011

I hope you will merge this, because right now, C2SStreams are never disconnected. I just used the end event on the socket...

Owner

astro commented Nov 28, 2011

I'd rather have standard event names, like end or close; whatever normal client connections are doing already: end means half-closed socket (no further incoming data), close is the final fd deletion.

There is online instead of connect because an XMPP connection has to wait for authentication to pass before being usable. If you only had seen my krtconf talk ;-)

With a standard event name, I'd be happy to merge. Please always mention if you want a 0.3.1 release ASAP.

Contributor

julien51 commented Nov 28, 2011

Oki, sending you another pull request right away :)

Contributor

julien51 commented Nov 28, 2011

Oh, and yes, it would be amazing if you could do a 0.3.1 release ASAP :)

astro added a commit that referenced this pull request Nov 29, 2011

@astro astro merged commit 4ecef07 into xmppjs:master Nov 29, 2011

Owner

astro commented Nov 29, 2011

0.3.1 out with that and another fix. Thanks, Julien!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment