Added support for legacy SSL and SASL EXTERNAL #64

Merged
merged 5 commits into from Apr 20, 2012

Conversation

Projects
None yet
2 participants
@eelcocramer
Contributor

eelcocramer commented Apr 19, 2012

Hi,

I added support for both legacy SSL (port 5223) and the EXTERNAL authentication mechanism (as described in XEP-0178) for both starttls and legacy SSL.

I tested this against my Openfire server.

Best regards,
Eelco

astro added a commit that referenced this pull request Apr 20, 2012

Merge pull request #64 from eelcocramer/master
Added support for legacy SSL and SASL EXTERNAL

@astro astro merged commit a41c729 into xmppjs:master Apr 20, 2012

@astro

This comment has been minimized.

Show comment
Hide comment
@astro

astro Apr 20, 2012

Member

Looks good, thank you.

I'm considering to convert all tabs to whitespace...

Member

astro commented Apr 20, 2012

Looks good, thank you.

I'm considering to convert all tabs to whitespace...

@eelcocramer

This comment has been minimized.

Show comment
Hide comment
@eelcocramer

eelcocramer Apr 21, 2012

Contributor

Thanks for pulling this in.

You might want to consider updating the readme so it is clear that the EXTERNAL client authentication is also supported. I forgot to add this myself :-/

I'll set my editor to use spaces instead of tabs for future changes...

Contributor

eelcocramer commented Apr 21, 2012

Thanks for pulling this in.

You might want to consider updating the readme so it is clear that the EXTERNAL client authentication is also supported. I forgot to add this myself :-/

I'll set my editor to use spaces instead of tabs for future changes...

@eelcocramer

This comment has been minimized.

Show comment
Hide comment
@eelcocramer

eelcocramer Apr 23, 2012

Contributor

This gist has a sample on how to use legacy SSL / startTLS with SASL EXTERNAL:

https://gist.github.com/2469490

Contributor

eelcocramer commented Apr 23, 2012

This gist has a sample on how to use legacy SSL / startTLS with SASL EXTERNAL:

https://gist.github.com/2469490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment