New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause/resume/hashrate problem #328

Open
Sinner181 opened this Issue Jan 9, 2018 · 14 comments

Comments

Projects
None yet
3 participants
@Sinner181

Sinner181 commented Jan 9, 2018

Hi,
when a external command was submitted to your application, I receive an unlimted loop.

with sendmessage or postmessage only work correcly RESUME function ("r" char).

PAUSE and HASHRATE generate an unlimits row like:
[2018-01-09 03:02:09] paused, press r to resume
[2018-01-09 03:02:09] paused, press r to resume
[2018-01-09 03:02:09] paused, press r to resume
[2018-01-09 03:02:09] paused, press r to resume
[2018-01-09 03:02:09] paused, press r to resume
[2018-01-09 03:02:09] paused, press r to resume
[2018-01-09 03:02:10] paused, press r to resume
[2018-01-09 03:02:10] paused, press r to resume
[2018-01-09 03:02:10] paused, press r to resume
[2018-01-09 03:02:10] paused, press r to resume

I've try with normal cmd.exe and sendmessage/postmessage send correctly only one char, your application goes in a infinite loop and crash after some minutes.

Can you fix? repeat, ONLY Resume work correctly if sendmessage/postmessage send an "r" char.
Thanks.

@xmrig

This comment has been minimized.

Show comment
Hide comment
@xmrig

xmrig Jan 9, 2018

Owner

Can you provide minimum working code how you use sendmessage/postmessage to able me reproduce the issue.
Thank you.

Owner

xmrig commented Jan 9, 2018

Can you provide minimum working code how you use sendmessage/postmessage to able me reproduce the issue.
Thank you.

@Sinner181

This comment has been minimized.

Show comment
Hide comment
@Sinner181

Sinner181 Jan 9, 2018

A simple PostMessage function:

PostMessage(hwnd, WM_CHAR, $50 ,0 ); (where $50 is P char)

See screenshot, thanks.

loop

Sinner181 commented Jan 9, 2018

A simple PostMessage function:

PostMessage(hwnd, WM_CHAR, $50 ,0 ); (where $50 is P char)

See screenshot, thanks.

loop

@Sinner181

This comment has been minimized.

Show comment
Hide comment
@Sinner181

Sinner181 Jan 9, 2018

If I send

PostMessage(hwnd, WM_CHAR, $52 ,0 ); (where $52 is R char)

it work correctly and no loop appears.

Sinner181 commented Jan 9, 2018

If I send

PostMessage(hwnd, WM_CHAR, $52 ,0 ); (where $52 is R char)

it work correctly and no loop appears.

@Sinner181

This comment has been minimized.

Show comment
Hide comment
@Sinner181

Sinner181 commented Jan 10, 2018

No news?

@xmrig

This comment has been minimized.

Show comment
Hide comment
@xmrig

xmrig Jan 10, 2018

Owner

Probably you send P char very often in loop or something. Anyway I added guard, now it should be not a issue. Please check.

Owner

xmrig commented Jan 10, 2018

Probably you send P char very often in loop or something. Anyway I added guard, now it should be not a issue. Please check.

@Sinner181

This comment has been minimized.

Show comment
Hide comment
@Sinner181

Sinner181 Jan 10, 2018

No, I'm sure to send only one char P without any loop. (I'm programmer since 20 years ;)

Please see below:
resume work

I press P with keyboard (and work), I send "R" char with postmessage and work correctly.

If I replace "R" char with "P" char in SAME function, your application goes in infinite loop.

"P" and "H" char sended with postmessage generate an infinite loop......

If I Send with the same function "P" or "R" or "H" in cmd.exe, it show only ONE char sended.

Problem persist...

I can't continue my project if you don't resolve this bug.
thanks.

Sinner181 commented Jan 10, 2018

No, I'm sure to send only one char P without any loop. (I'm programmer since 20 years ;)

Please see below:
resume work

I press P with keyboard (and work), I send "R" char with postmessage and work correctly.

If I replace "R" char with "P" char in SAME function, your application goes in infinite loop.

"P" and "H" char sended with postmessage generate an infinite loop......

If I Send with the same function "P" or "R" or "H" in cmd.exe, it show only ONE char sended.

Problem persist...

I can't continue my project if you don't resolve this bug.
thanks.

@xmrig

This comment has been minimized.

Show comment
Hide comment
@xmrig

xmrig Jan 10, 2018

Owner

Problem still persist after this e654022 commit?

Owner

xmrig commented Jan 10, 2018

Problem still persist after this e654022 commit?

@Sinner181

This comment has been minimized.

Show comment
Hide comment
@Sinner181

Sinner181 Jan 10, 2018

I'm not using your source, I need a new release with this fix....

I use yours xmrig64.exe xmrig32.exe directly.

Is possible?

Sinner181 commented Jan 10, 2018

I'm not using your source, I need a new release with this fix....

I use yours xmrig64.exe xmrig32.exe directly.

Is possible?

@Sinner181

This comment has been minimized.

Show comment
Hide comment
@Sinner181

Sinner181 Jan 11, 2018

Can you rebuild application please? I don't want install other application....thanks.

Sinner181 commented Jan 11, 2018

Can you rebuild application please? I don't want install other application....thanks.

@Mila432

This comment has been minimized.

Show comment
Hide comment
@Mila432

Mila432 Jan 11, 2018

@Sinner181 nice troll

I'm programmer since 20 years
can’t even compile the source

Mila432 commented Jan 11, 2018

@Sinner181 nice troll

I'm programmer since 20 years
can’t even compile the source

@Sinner181

This comment has been minimized.

Show comment
Hide comment
@Sinner181

Sinner181 Jan 11, 2018

What mean? I'm delphi programmer.... I don't want install other softwares in my computer....it's simple.

Sinner181 commented Jan 11, 2018

What mean? I'm delphi programmer.... I don't want install other softwares in my computer....it's simple.

@Sinner181

This comment has been minimized.

Show comment
Hide comment
@Sinner181

Sinner181 Jan 11, 2018

There is a bug in this software, and is not mine =)

Sinner181 commented Jan 11, 2018

There is a bug in this software, and is not mine =)

@Sinner181

This comment has been minimized.

Show comment
Hide comment
@Sinner181

Sinner181 Jan 12, 2018

Thanks, now work correctly! =)
(I set 2% fee for you in my application)
See you, bye

Sinner181 commented Jan 12, 2018

Thanks, now work correctly! =)
(I set 2% fee for you in my application)
See you, bye

@Sinner181 Sinner181 closed this Jan 12, 2018

@Sinner181

This comment has been minimized.

Show comment
Hide comment
@Sinner181

Sinner181 Jan 23, 2018

Hi, there is the same problem with

Nvidia cuda 8
Nvidia cuda 9
AMD 32bit
AMD 64bit

I'm trying to add in my project but is impossible with this issue.
Can you fix like xmrig cpu version? Binary release too if possible.

Thank you!

Sinner181 commented Jan 23, 2018

Hi, there is the same problem with

Nvidia cuda 8
Nvidia cuda 9
AMD 32bit
AMD 64bit

I'm trying to add in my project but is impossible with this issue.
Can you fix like xmrig cpu version? Binary release too if possible.

Thank you!

@Sinner181 Sinner181 reopened this Jan 23, 2018

Bendr0id pushed a commit to Bendr0id/xmrigCC that referenced this issue Apr 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment