New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visual c++ 2015 : MASM : error A2070: invalid instruction operands #768

Closed
adevelopcr opened this Issue Oct 1, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@adevelopcr

adevelopcr commented Oct 1, 2018

I got several of this error during build for x64 release and thus the linker failed at the the end of compilation to link against xmrig-asm.lib

these are some of the errors :

1>------ Build started: Project: xmrig-asm, Configuration: Release x64 ------
1>  Assembling E:\fx\xmrig-project\xmrig-2.8.0\src\crypto\asm\cnv2_main_loop.asm...
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2150: word register cannot be first operand
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2070: invalid instruction operands
1>MASM : error A2150: word register cannot be first operand
1>MASM : error A2150: word register cannot be first operand
1>MASM : error A2150: word register cannot be first operand
1>6) : fatal error A1012: error count exceeds 100; stopping assembly

2>LINK : fatal error LNK1181: cannot open input file 'Release\xmrig-asm.lib'
@adevelopcr

This comment has been minimized.

Show comment
Hide comment
@adevelopcr

adevelopcr Oct 1, 2018

I built it successfully with mingw-w64 but it doesn't build with visual studio 2015
what happened ! have anything changed in 2.8 release or should I do anything special ?

adevelopcr commented Oct 1, 2018

I built it successfully with mingw-w64 but it doesn't build with visual studio 2015
what happened ! have anything changed in 2.8 release or should I do anything special ?

@adevelopcr

This comment has been minimized.

Show comment
Hide comment
@adevelopcr

adevelopcr Oct 1, 2018

I checked the old releases and it didn't have the asm folder or the asm files and didn't use the assembler
so is the new version incompatible with visual studio 2015 ?

adevelopcr commented Oct 1, 2018

I checked the old releases and it didn't have the asm folder or the asm files and didn't use the assembler
so is the new version incompatible with visual studio 2015 ?

@adevelopcr

This comment has been minimized.

Show comment
Hide comment
@adevelopcr

adevelopcr commented Oct 1, 2018

@xmrig

This comment has been minimized.

Show comment
Hide comment
@xmrig

xmrig Oct 1, 2018

Owner

I will check it tomorrow, likely need add some workarounds for MSVC 2015. asm code successfully compiled with MSVC 2017.

Owner

xmrig commented Oct 1, 2018

I will check it tomorrow, likely need add some workarounds for MSVC 2015. asm code successfully compiled with MSVC 2017.

@adevelopcr

This comment has been minimized.

Show comment
Hide comment
@adevelopcr

adevelopcr Oct 2, 2018

Can I build with option WITH_ASM=OFF

adevelopcr commented Oct 2, 2018

Can I build with option WITH_ASM=OFF

@adevelopcr

This comment has been minimized.

Show comment
Hide comment
@adevelopcr

adevelopcr Oct 2, 2018

yes it built but I think I'll lose some performance , am I right ?

adevelopcr commented Oct 2, 2018

yes it built but I think I'll lose some performance , am I right ?

@xmrig

This comment has been minimized.

Show comment
Hide comment
@xmrig

xmrig Oct 2, 2018

Owner

Fixed in dev branch.
Your are right, without ASM you lose performance for cn/2 with single and double modes. More about asm option #753 (comment).
Thank you.

Owner

xmrig commented Oct 2, 2018

Fixed in dev branch.
Your are right, without ASM you lose performance for cn/2 with single and double modes. More about asm option #753 (comment).
Thank you.

@xmrig xmrig added the bug label Oct 2, 2018

@xmrig xmrig added this to the v2.8.1 milestone Oct 3, 2018

@xmrig xmrig closed this Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment