Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed race condition in RandomX thread init #1146

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@SChernykh
Copy link
Contributor

commented Aug 28, 2019

Thread could deadlock if it started before dataset struct was allocated.
Thanks to crCr62U0 for reporting this.

Thread could deadlock if it started before dataset struct was allocated.
@xmrig

This comment has been minimized.

Copy link
Owner

commented Aug 28, 2019

In addition in branch feature-opencl init sequence changed: mining threads guaranteed starts only after dataset allocated and initialized to allow options like dataset_host works without side effects.
Thank you.

@xmrig xmrig merged commit af52e45 into xmrig:dev Aug 28, 2019
@xmrig xmrig added the bug label Aug 28, 2019
@xmrig xmrig added this to the v3 milestone Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.