Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved MSR subsystem code quality #2057

Merged
merged 7 commits into from Jan 23, 2021
Merged

Improved MSR subsystem code quality #2057

merged 7 commits into from Jan 23, 2021

Conversation

xmrig
Copy link
Owner

@xmrig xmrig commented Jan 23, 2021

Older code has following issues:

  • 2 different implementations for Windows and Linux, but with large parts of duplicated code.
  • Different MSR access API or Windows and Linux without generic interface.

This PR solved it by implementing the new unified MSR API (Msr class) and new unified RandomX MSR implementation (RxMsr class) without code duplication.

@xmrig xmrig added the randomx label Jan 23, 2021
@xmrig xmrig added this to the v6 milestone Jan 23, 2021
@xmrig xmrig merged commit 05b2260 into dev Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
randomx
Projects
None yet
Milestone
v6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xmrig @coldiron