Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix the createKeyIndex problem with neo4j after a batch insertion mode. #10

Open
wants to merge 1 commit into from

2 participants

@purbon

Fix bug xnlogic/pacer#51, so now even after the usage of a BatchInserter or a GraphML Import, whenever we create a key index this is properly fix.

I've read, and test, some other strategies like passing some variables to the Neo4j constructor on runtime, but never success with anyone of that, so I think to flush the index content just in case of a neo4j graph is a proper solution to that. However I'm open to suggestions ;-)

@pangloss pangloss commented on the diff
lib/pacer-neo4j/blueprints_graph.rb
@@ -10,6 +10,11 @@ def tx_depth
tgi[:tx_depth] || 0
end
+ def createKeyIndex(name, clazz, *params)
+ super(name, clazz, *params)
+ commit()
@pangloss Owner

I'm wondering if this fix should be submitted directly to the Blueprints Neo4j project. What do you think?

@purbon
purbon added a note

I'm not sure about it, as far as we're speaking about a Neo4j problem (see neo4j/neo4j#173) first of all we should understand or ask if the blueprints project make you create the key index before or after the GraphML import. I was unable to see any bug report regarding that, so I understand the current blueprint behaviour is to create the key index before the graphml import in the case of neo4j, but I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 10, 2013
  1. @purbon
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 0 deletions.
  1. +5 −0 lib/pacer-neo4j/blueprints_graph.rb
View
5 lib/pacer-neo4j/blueprints_graph.rb
@@ -10,6 +10,11 @@ def tx_depth
tgi[:tx_depth] || 0
end
+ def createKeyIndex(name, clazz, *params)
+ super(name, clazz, *params)
+ commit()
@pangloss Owner

I'm wondering if this fix should be submitted directly to the Blueprints Neo4j project. What do you think?

@purbon
purbon added a note

I'm not sure about it, as far as we're speaking about a Neo4j problem (see neo4j/neo4j#173) first of all we should understand or ask if the blueprints project make you create the key index before or after the GraphML import. I was unable to see any bug report regarding that, so I understand the current blueprint behaviour is to create the key index before the graphml import in the case of neo4j, but I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ end
+
def autoStartTransaction
if allow_auto_tx or tx_depth != 0
super
Something went wrong with that request. Please try again.