Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine search by query #1

Merged
merged 4 commits into from Sep 28, 2019
Merged

Refine search by query #1

merged 4 commits into from Sep 28, 2019

Conversation

item4
Copy link
Contributor

@item4 item4 commented Sep 26, 2019

No description provided.

xnuk
xnuk approved these changes Sep 26, 2019
Copy link
Owner

@xnuk xnuk left a comment

대충 어케 할지 감이 왓서요 감사합니다

src/app.ts Outdated Show resolved Hide resolved
src/app.ts Outdated
({ area, city }) => {
if (searchMethod(city, maybe_city)) {
if (chunks.length > 0) {
return searchMethod(area, chunks.join(' '));
Copy link
Owner

@xnuk xnuk Sep 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

창원 마산합포도 되게 해주세요(?

src/app.ts Outdated Show resolved Hide resolved
@xnuk
Copy link
Owner

@xnuk xnuk commented Sep 26, 2019

사실 이걸 윾이에 넣을 악랄한 계획을 가지고 있었는데 HTTP 리퀘스트 양 보고 접었습니다

(area && searchMethod(area, areaname)) ||
(city && searchMethod(city, areaname)),
({ area, city }) => {
const spaceless_area = area.replace(/ /g, '')
Copy link
Owner

@xnuk xnuk Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음믕 이걸로 되나요?

Copy link
Contributor Author

@item4 item4 Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

양쪽 다 창원 마산합포창원마산합포 로 만들고 비교하니까 될겁니다. 그래도 영 미덥지 않다면 fuzzy search 써야겠죠

Copy link
Owner

@xnuk xnuk Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

호에

Copy link
Owner

@xnuk xnuk Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하지만하지만 저장되는 건 창원시 마산합포구인 걸요

@xnuk xnuk merged commit 7267b25 into xnuk:master Sep 28, 2019
@item4 item4 deleted the search branch Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants