Merged
Conversation
xnuk
approved these changes
Sep 26, 2019
src/app.ts
Outdated
| ({ area, city }) => { | ||
| if (searchMethod(city, maybe_city)) { | ||
| if (chunks.length > 0) { | ||
| return searchMethod(area, chunks.join(' ')); |
Owner
|
사실 이걸 윾이에 넣을 악랄한 계획을 가지고 있었는데 HTTP 리퀘스트 양 보고 접었습니다 |
xnuk
reviewed
Sep 27, 2019
| (area && searchMethod(area, areaname)) || | ||
| (city && searchMethod(city, areaname)), | ||
| ({ area, city }) => { | ||
| const spaceless_area = area.replace(/ /g, '') |
Contributor
Author
There was a problem hiding this comment.
양쪽 다 창원 마산합포 를 창원마산합포 로 만들고 비교하니까 될겁니다. 그래도 영 미덥지 않다면 fuzzy search 써야겠죠
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.