Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build/spdk): use debug for SPDK if enabled for xNVMe #352

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

karlowich
Copy link
Contributor

If xNVMe is built with buildtype=debug, configure SPDK to use debug too.

I believe this is useful for debugging

If xNVMe is built with buildtype=debug, configure SPDK to use debug too.

Signed-off-by: Karl Bonde Torp <k.torp@samsung.com>
@safl safl added the enhancement New feature or request label Sep 27, 2023
@safl safl added this to the v0.7.2 milestone Sep 27, 2023
Copy link
Member

@safl safl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea.

@safl safl merged commit dc1880d into xnvme:next Sep 27, 2023
30 checks passed
@karlowich karlowich deleted the spdk-debug branch November 29, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants