Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo/Redo works instable on Windows/Linux #1530

Closed
brusherru opened this issue Nov 7, 2018 · 3 comments
Closed

Undo/Redo works instable on Windows/Linux #1530

brusherru opened this issue Nov 7, 2018 · 3 comments
Assignees
Projects

Comments

@brusherru
Copy link
Contributor

brusherru commented Nov 7, 2018

Environment

  • Scope: desktop IDE
  • Version: 0.25.2
  • OS: Windows 10 / Linux

Undo/redo works fine for moving nodes or adding new node from Project Browser, but when User adds a new node using i hotkey it makes undo/redo works strange (need to click hotkey few times).

Reported on forum: https://forum.xod.io/t/ctrl-z-ctrl-shift-z-no-works/1267

Steps to reproduce

  1. Open XOD IDE
  2. Click i hotkey
  3. Type "clock" and press "enter"
  4. Move the node
  5. Press Ctrl+Z

Expected behavior

Node is moved back.

Actual behavior

Nothing happened.
If click few more times it will do undo.
The same thing with "redo".

Also, if you click "undo" in menu item it will react instantly.

I did a small investigation, place console.log in accelerator function and in the Editor's command function. The last one was not called at all, accelerator function called only after few clicks on the hotkey.

@nkrkv nkrkv changed the title Undo/Redo works not stable on Windows Undo/Redo works instable on Windows Nov 7, 2018
@nkrkv
Copy link
Member

nkrkv commented Nov 7, 2018

I can confirm, it reproduces on Linux as well

@brusherru brusherru changed the title Undo/Redo works instable on Windows Undo/Redo works instable on Windows/Linux Nov 7, 2018
@evgenykochetkov evgenykochetkov added this to To do in Hotfixes Nov 12, 2018
@evgenykochetkov evgenykochetkov moved this from To do to In progress in Hotfixes Nov 13, 2018
@evgenykochetkov evgenykochetkov self-assigned this Nov 13, 2018
@Cesar-S
Copy link
Contributor

Cesar-S commented Nov 22, 2018

hi, in Windows solved. Thanks

@evgenykochetkov evgenykochetkov moved this from In progress to Done in Hotfixes Nov 23, 2018
@nkrkv
Copy link
Member

nkrkv commented Nov 27, 2018

Closed by #1556

@nkrkv nkrkv closed this as completed Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Hotfixes
  
Done
Development

No branches or pull requests

4 participants