Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tabtests in web worker #1648

Merged
merged 2 commits into from
Jan 28, 2019
Merged

Run tabtests in web worker #1648

merged 2 commits into from
Jan 28, 2019

Conversation

brusherru
Copy link
Contributor

There is no issue, but this is a prerequisite for issues about simulation.

Also, I've removed runSuite and vendored runtime.js from xod-cloud-tabtest, because now we get an URL from service response and then import it into the worker. So I have to remove end to end test, but I'll bring something like this back in the next pull requests.

packages/xod-client/src/debugger/messages.js Outdated Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
package.json Show resolved Hide resolved
packages/xod-client/src/editor/actions.js Outdated Show resolved Hide resolved
packages/xod-client/src/editor/actions.js Outdated Show resolved Hide resolved
packages/xod-client/src/workers/reducer.js Outdated Show resolved Hide resolved
packages/xod-client/src/workers/run.js Show resolved Hide resolved
packages/xod-client/src/workers/run.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
packages/xod-client/webpack.config.js Outdated Show resolved Hide resolved
packages/xod-client/src/editor/actions.js Outdated Show resolved Hide resolved
packages/xod-client/src/workers/reducer.js Outdated Show resolved Hide resolved
)
)
.then(
abortOrPass(({ stdout, worker }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These repetitive .then(abortOrPass(...)) is yet another reason to upgrade to latest Ramda. Its R.composeWith and R.pipeWith make this chain more elegant and shallowly nested.

Just a note, not a change request.

Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get yarn.lock changes after running yarn.

$ yarn
...
$ git diff --stat
 yarn.lock | 194 +++++++++++++++++++++++++---------------------------------------------------------------------------------
 1 file changed, 46 insertions(+), 148 deletions(-)

Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very basic scenario of running xod/math/abs tests hangs on my machine. In console:

Uncaught (in promise) TypeError: Cannot read property 'terminate' of undefined
    at actions.js:787
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188)

@brusherru brusherru force-pushed the run-tabtest-in-webworker branch 2 times, most recently from 0ae721b to 36838d9 Compare January 28, 2019 10:43
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@brusherru brusherru merged commit 80dc1b7 into master Jan 28, 2019
@brusherru brusherru deleted the run-tabtest-in-webworker branch January 28, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants