-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tabtests in web worker #1648
Conversation
e3826ea
to
e20e793
Compare
) | ||
) | ||
.then( | ||
abortOrPass(({ stdout, worker }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These repetitive .then(abortOrPass(...))
is yet another reason to upgrade to latest Ramda. Its R.composeWith
and R.pipeWith
make this chain more elegant and shallowly nested.
Just a note, not a change request.
e20e793
to
9cfe0cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get yarn.lock
changes after running yarn
.
$ yarn
...
$ git diff --stat
yarn.lock | 194 +++++++++++++++++++++++++---------------------------------------------------------------------------------
1 file changed, 46 insertions(+), 148 deletions(-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A very basic scenario of running xod/math/abs
tests hangs on my machine. In console:
Uncaught (in promise) TypeError: Cannot read property 'terminate' of undefined
at actions.js:787
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188)
0ae721b
to
36838d9
Compare
…wasm runtime from service
36838d9
to
fd5ae29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There is no issue, but this is a prerequisite for issues about simulation.
Also, I've removed
runSuite
and vendoredruntime.js
fromxod-cloud-tabtest
, because now we get an URL from service response and then import it into the worker. So I have to remove end to end test, but I'll bring something like this back in the next pull requests.