Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tweak-strings compile for esp8266 boards #1902

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@evgenykochetkov
Copy link
Contributor

evgenykochetkov commented Nov 1, 2019

Before, attempting to use tweak-string-* nodes on esp8266 would result in the following error:

In constructor 'xod::xod__debug__tweak_string_32::State::State()':
error: array used as initializer
     State() : view(buff) {}
                        ^
@nkrkv
nkrkv approved these changes Nov 5, 2019
Copy link
Member

nkrkv left a comment

LGTM

@evgenykochetkov evgenykochetkov merged commit 1140653 into master Nov 6, 2019
4 checks passed
4 checks passed
ci/circleci: test-cpp Your tests passed on CircleCI!
Details
ci/circleci: verify-linux Your tests passed on CircleCI!
Details
ci/circleci: verify-macos Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
@evgenykochetkov evgenykochetkov deleted the fix-tweak-strings-for-esp8266-boards branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.