Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arduino-cli and spaces in username on Windows #1906

Merged
merged 3 commits into from Dec 2, 2019

Conversation

@brusherru
Copy link
Contributor

brusherru commented Nov 12, 2019

It fixes #1723

@brusherru brusherru requested review from nkrkv and evgenykochetkov Nov 12, 2019
@brusherru brusherru self-assigned this Nov 12, 2019
@knopki
knopki approved these changes Nov 12, 2019
Copy link
Contributor

knopki left a comment

👍
Is xod-cli tested too?

@knopki

This comment has been minimized.

Copy link
Contributor

knopki commented Nov 13, 2019

What else needs testing:

  • killing child process
  • stale process that prevents closing IDE (I remember such bug)
@brusherru

This comment has been minimized.

Copy link
Contributor Author

brusherru commented Nov 13, 2019

@nkrkv removed shell: true for all platforms and tested.
The xod-cli and killing child processes on closing IDE tested too.
Check it out, please.

const IS_WIN = os.platform() === 'win32';
const escapeSpacesNonWin = R.unless(() => IS_WIN, R.replace(/\s/g, '\\ '));
Comment on lines -20 to -14

This comment has been minimized.

Copy link
@nkrkv

nkrkv Nov 13, 2019

Member

❤️ for OS neutrality

@brusherru brusherru changed the base branch from 0.31.x to master Dec 2, 2019
@brusherru brusherru force-pushed the fix-1723-spaces-on-win branch from f0600f6 to 1b85eaa Dec 2, 2019
@brusherru brusherru merged commit 147ee03 into master Dec 2, 2019
4 checks passed
4 checks passed
ci/circleci: test-cpp Your tests passed on CircleCI!
Details
ci/circleci: verify-linux Your tests passed on CircleCI!
Details
ci/circleci: verify-macos Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
@brusherru brusherru deleted the fix-1723-spaces-on-win branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.