From be9d0f707611b0eb3fc5af2109aa3c436aa76397 Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Tue, 26 Apr 2016 01:11:14 +0700 Subject: [PATCH] add `eslint-plugin-import` --- cli.js | 2 +- config/plugins.js | 25 +++++++++++++++++++++---- package.json | 2 +- test/fixtures/overrides/package.json | 5 ++++- 4 files changed, 27 insertions(+), 7 deletions(-) diff --git a/cli.js b/cli.js index 7d076a90..e43904d0 100755 --- a/cli.js +++ b/cli.js @@ -1,5 +1,5 @@ #!/usr/bin/env node -/* eslint-disable import-order/import-order */ +/* eslint-disable import/order */ 'use strict'; var debug = require('debug')('xo'); diff --git a/config/plugins.js b/config/plugins.js index 94065c57..311319cd 100644 --- a/config/plugins.js +++ b/config/plugins.js @@ -2,10 +2,10 @@ module.exports = { plugins: [ 'no-use-extend-native', - 'import-order', 'ava', 'xo', - 'promise' + 'promise', + 'import' ], extends: [ 'plugin:ava/recommended', @@ -13,7 +13,24 @@ module.exports = { ], rules: { 'no-use-extend-native/no-use-extend-native': 2, - 'import-order/import-order': 2, - 'promise/param-names': 2 + 'promise/param-names': 2, + // disabled because of https://github.com/benmosher/eslint-plugin-import/issues/268 + // 'import/default': 2, + 'import/export': 2, + 'import/extensions': [2, 'never'], + 'import/imports-first': 2, + // disabled because of https://github.com/benmosher/eslint-plugin-import/issues/268 + // 'import/named': 2, + 'import/namespace': 2, + 'import/no-amd': 2, + // enable this sometime in the future when Node.js has ES2015 module support + // 'import/no-commonjs': 2, + // looks useful, but too unstable at the moment + // 'import/no-deprecated': 2, + 'import/no-extraneous-dependencies': 2, + 'import/no-named-as-default-member': 2, + 'import/no-named-as-default': 2, + 'import/no-unresolved': [2, {commonjs: true}], + 'import/order': 2 } }; diff --git a/package.json b/package.json index 162c4d08..d3bc65ff 100644 --- a/package.json +++ b/package.json @@ -70,7 +70,7 @@ "eslint-formatter-pretty": "^0.2.1", "eslint-plugin-ava": "^2.0.0", "eslint-plugin-babel": "^3.1.0", - "eslint-plugin-import-order": "^2.0.0", + "eslint-plugin-import": "^1.6.0", "eslint-plugin-no-use-extend-native": "^0.3.2", "eslint-plugin-promise": "^1.1.0", "eslint-plugin-xo": "^0.3.1", diff --git a/test/fixtures/overrides/package.json b/test/fixtures/overrides/package.json index 9029945e..d1bf7558 100644 --- a/test/fixtures/overrides/package.json +++ b/test/fixtures/overrides/package.json @@ -12,6 +12,9 @@ "files": "test/foo.js", "space": 4 } - ] + ], + "rules": { + "import/no-extraneous-dependencies": 0 + } } }