Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn all paths `cwd`-relative before linting #372

Merged
merged 2 commits into from Apr 29, 2019

Conversation

Projects
None yet
2 participants
@futpib
Copy link
Contributor

commented Jan 20, 2019

fix #223

@sindresorhus

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

It feels weird to turn paths relative. What if the overrides specify absolute paths? Wouldn't it make more sense to make the overrides paths absolute instead?

@futpib

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

What if the overrides specify absolute paths?

Should overrides even support absolute paths? If you put an absolute path override in you package.json it probably won't work on anyone else's setup or in CI. For instance /Users/zanona/Developer/my-app/packages/shop-app/** (from #223 (comment)) clearly won't work for anyone else (username is in the path, the path is Mac-specific, etc.)

Wouldn't it make more sense to make the overrides paths absolute instead?

Would be hard to do this correctly since override paths are minimatch globs.

@sindresorhus

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

That's a good point.

@sindresorhus sindresorhus merged commit 3033fcd into xojs:master Apr 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sindresorhus

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

You need to add this PR to https://issuehunt.io/r/xojs/xo/issues/223 to get the bounty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.