Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert project to module #566

Merged
merged 7 commits into from Jul 1, 2021
Merged

Convert project to module #566

merged 7 commits into from Jul 1, 2021

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Jul 1, 2021

Questions:

  • Do we still need support global xo to run local one?
  • Don't know how to make test/open-report.js test pass, now skipped.

@sindresorhus
Copy link
Member

sindresorhus commented Jul 1, 2021

Do we still need support global xo to run local one?

No, we should move to npx xo. Global XO doesn't currently work anyway: #546

@@ -52,8 +46,7 @@ resolveFrom.silent = (moduleId, fromDirectory) => {
} catch { }
};

// TODO: Use `resolveModule(normalizePackageName(name), import.meta.url);` when moving to ESM then to `import.meta.resolve(normalizePackageName(name))` when supported
Copy link
Member

@sindresorhus sindresorhus Jul 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please preserve part of this todo comment.

fisker added 2 commits Jul 1, 2021
# Conflicts:
#	cli-main.js
#	cli.js
#	lib/open-report.js
#	lib/options-manager.js
#	package.json
#	test/cli-main.js
#	test/cli.js
@fisker fisker marked this pull request as ready for review Jul 1, 2021
@fisker fisker mentioned this pull request Jul 1, 2021
@sindresorhus sindresorhus merged commit 41c8f39 into xojs:main Jul 1, 2021
3 checks passed
@fisker fisker deleted the esm branch Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants