New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the hlgroup of xolox#misc#msg#info #16

Merged
merged 1 commit into from Mar 15, 2015

Conversation

Projects
None yet
2 participants
@roryokane
Contributor

roryokane commented Oct 14, 2014

It used the hlgroup 'Title', but this does not accurately represent an informational message. As one can see from :help hl-Title and the example commands it lists, 'Title' is meant for section headings in long output, not a single-line message.

This inapplicability was especially noticeable in my color scheme (Solarized), which shows 'Title' in an orange-red color. This color does a good job of marking titles in long output, but it makes a single-line message look like an error.

Instead, I have made #info use no highlighting – the hlgroup 'None'. I think this hlgroup most accurately represents an “informational message”. It is the same hlgroup that searches are echoed with when pressing n and N, which also seem like informational messages.

While I am editing hlgroups, I also made the capitalization of their names the same as what Vim uses when you run the :highlight command. This makes multi-word names a little easier to read, and aids debugging against the output of :highlight.

Before:

before: an info message from vim-session that looks like an error message

After:

after: an info message from vim-session that properly looks like an info message

Change the hlgroup of xolox#misc#msg#info
It used the hlgroup 'Title', but this does not accurately represent an informational message. As one can see from `:help hl-Title` and the example commands it lists, 'Title' is meant for section headings in long output, not a single-line message.

This inapplicability was especially noticeable in my color scheme (Solarized), which shows 'Title' in an orange-red color. This color does a good job of marking titles in long output, but it makes a single-line message look like an error.

Instead, I have made #info use no highlighting – the hlgroup 'None'. I think this hlgroup most accurately represents an “informational message”. It is the same hlgroup that searches are echoed with when pressing `n` and `N`, which also seem like informational messages.

While I am editing hlgroups, I also made the capitalization of their names the same as what Vim uses when you run the `:highlight` command. This makes multi-word names a little easier to read, and aids debugging against the output of `:highlight`.

@xolox xolox merged commit 26f1591 into xolox:master Mar 15, 2015

@xolox

This comment has been minimized.

Show comment
Hide comment
@xolox

xolox Mar 15, 2015

Owner

Hi Rory!

Sorry for the late response and thanks for the pull request. Thanks specifically for your detailed description which shows you put some thought into this and looked through the Vim documentation to find the best applicable highlighting group. Your arguments are sound and I can't find a better alternative so I've merged your pull request without changes (I just updated the docstring).

Happy Vimming!

Owner

xolox commented Mar 15, 2015

Hi Rory!

Sorry for the late response and thanks for the pull request. Thanks specifically for your detailed description which shows you put some thought into this and looked through the Vim documentation to find the best applicable highlighting group. Your arguments are sound and I can't find a better alternative so I've merged your pull request without changes (I just updated the docstring).

Happy Vimming!

@roryokane roryokane deleted the roryokane:info-highlighting branch Mar 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment