Error when searching for non-existing string with :SearchNotes #47

Closed
jfremstad opened this Issue Aug 25, 2013 · 2 comments

Projects

None yet

2 participants

@jfremstad

I have two notes which do not contain "skdjfh".

:SearchNote skdjfh gives this error:

notes.vim 0.23.2: Searching notes using keyword index ..
Error detected while processing function
xolox#notes#search..<SNR>45_internal_search..<SNR>45_vimgrep_wrapper:
line    9:
E683: File name missing or invalid pattern
Error detected while processing function
xolox#notes#search..<SNR>45_internal_search:
line   30:
E171: Missing :endif
Error detected while processing function xolox#notes#search:
line   18:
E171: Missing :endif

Edit: A similar error message when trying this aswell: :SearchNote /skdjfh/

@xolox xolox added a commit that referenced this issue Sep 2, 2013
@xolox Improvements to search-notes.py
 - Bug fix: Output encoding of listed keywords
 - Bug fix: Don't print empty line when there's no matches
   (related to issue #47 but not a complete solution ... yet)
 - Move index version to variable

See also issue #47 on GitHub:
  #47
db6f35b
@xolox xolox added a commit that referenced this issue Sep 2, 2013
@xolox Bug fix for communication between notes.vim and search-notes.py*
The problem was that there was no way to distinguish the two cases:

  1. The script successfully reported no matches.
  2. The script failed with an error (or couldn't even be executed).

Now the two cases are properly disambiguated.

See issue #47 on GitHub:
  #47
1e55003
@xolox xolox added a commit that referenced this issue Sep 2, 2013
@xolox Translate Vim's awkward E480 stack trace into a clean error message
See issue #47 on GitHub:
  #47
14838be
@xolox
Owner
xolox commented Sep 2, 2013

I think both problems you reported are now fixed, can you confirm? If the problem is resolved feel free to close this issue. Thanks for the feedback!

@jfremstad

The problems are fixed, and it works perfectly. Thank you for the fix!

@jfremstad jfremstad closed this Sep 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment