Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript output is not supported #4

Closed
JeromeA opened this issue May 7, 2016 · 1 comment
Closed

Javascript output is not supported #4

JeromeA opened this issue May 7, 2016 · 1 comment
Assignees
Milestone

Comments

@JeromeA
Copy link

@JeromeA JeromeA commented May 7, 2016

--js_out option was added to Google protoc 5 months ago, it would be nice to be able to generate javascript from a proto definition using this plugin.

@sergei-ivanov sergei-ivanov self-assigned this May 17, 2016
@sergei-ivanov sergei-ivanov added this to the 0.6 milestone May 17, 2016
@sergei-ivanov
Copy link
Member

@sergei-ivanov sergei-ivanov commented May 17, 2016

Hello @JeromeA,

At the moment, support for each new output type results in a creation of two new goals, and there are already too many of them. For the time being, you can use compile-custom goal, as described in #1, for example:

    <plugin>
        <groupId>org.xolstice.maven.plugins</groupId>
        <artifactId>protobuf-maven-plugin</artifactId>
        <version>0.5.0</version>
        <executions>
          <execution>
            <id>protobuf-compile-js</id>
            <goals>
                <goal>compile-custom</goal>
            </goals>
            <configuration>
                <pluginId>js</pluginId>
            </configuration>
          </execution>
        </executions>
    </plugin>

In the longer term, I need to find enough time to rewrite the entire plugin configuration, so that it's reduced to only two goals with multiple pluggable output configurations.

Please add votes (reactions to the headline comment) to help me gauge the demand for this feature.

Kind regards,
Sergei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants