Documentation Change: Use bash-completion2 in OSX #2111

Closed
EntilZha opened this Issue Jan 26, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@EntilZha
Contributor

EntilZha commented Jan 26, 2017

Creating an issue to document the issue/reason for changing documentation, so I can link to it from the documentation before submitting a PR, and if anyone runs into the issue they can see the solution.

The original issue came up on macOS 10.12.2 using bash 4.4, xonsh 0.5.2, and bash completion 1.3 (installed via brew install bash-completion as per the docs). The basic issue is xonsh sometimes expanding ~ when it shouldn't or doing it incorrectly. Xonsh tab completed the following when prompt-toolkit was installed:

  1. ls ~/Down -> ls ~/Downloads
  2. vim ~/Down -> ~/Down/Users/pedro/Downloads/

Similar behavior to (1) was observed with most commands, but with emacs behavior (2) was observed. When using readline tab completed to /Users/pedro/Downloads/ which works but not desirable to expand the ~.

After running these commands to upgrade bash completion to v2 the problem went away and expected behavior re-emerged

brew unlink bash-completion
brew install bash-completion2

I'll be submitting a PR with the documentation change in a moment.

@scopatz

This comment has been minimized.

Show comment
Hide comment
@scopatz

scopatz Jan 26, 2017

Member

Thanks @EntilZha, feel free to close this

Member

scopatz commented Jan 26, 2017

Thanks @EntilZha, feel free to close this

@EntilZha

This comment has been minimized.

Show comment
Hide comment
@EntilZha

EntilZha Jan 26, 2017

Contributor

Thanks.

Contributor

EntilZha commented Jan 26, 2017

Thanks.

@EntilZha EntilZha closed this Jan 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment