Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed internal usage of NO_COLOR to reset #3835

Merged
merged 2 commits into from Oct 5, 2020
Merged

changed internal usage of NO_COLOR to reset #3835

merged 2 commits into from Oct 5, 2020

Conversation

scopatz
Copy link
Member

@scopatz scopatz commented Oct 5, 2020

Closes #3833 CC @gforsyth

This was referenced Oct 5, 2020
Closed
Closed
gforsyth
gforsyth approved these changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welp, that's hilarious. Looks good. I'll merge after CI passes.

Thanks @scopatz!

@scopatz
Copy link
Member Author

scopatz commented Oct 5, 2020

haha yeah, mea culpa.... I really should have checked this in the original PR 😉

@gforsyth
Copy link
Collaborator

gforsyth commented Oct 5, 2020

whoops, also looks like #3833 was linked, instead of #3834

I'll reopen #3833 after the merge closes it.

@gforsyth gforsyth merged commit f9e0f07 into master Oct 5, 2020
@gforsyth gforsyth deleted the no-color-reset branch October 5, 2020 20:59
@gforsyth
Copy link
Collaborator

gforsyth commented Oct 5, 2020

Thanks, @scopatz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PTK completion prefix matching is broken
2 participants
@scopatz @gforsyth