Added functionality to fix broken XML. #1
…trol, given how mercurial it seems to be.
…nfirmed 12, probably more. Unsure what next broken one is). With 5k files, there will be one. Looking into automating tomorrow.
… know which passed and failed.
…e (rather than XML). Triple Quote fix is kludgey, and will probably have to be replaced (by optimizing the inner/outer quote methods instead)
…iple quotes, double dash) and some more quote stuff. Need to refactor quotes into separate files.
Interesting to see this in progress. :)
When integrating this into xoreos-tools / xoreos proper, the interface should probably be something like for Aurora::Small, i.e. a method that consumes a Common::SeekableReadStream * and spits out a fixed Common::SeekableReadStream *. It should probably live in the Aurora namespace, too.
In the method, you would create a Common::MemoryWriteStreamDynamic  and writeString() your fixed strings into that. Of course, our stream classes are primed to read/write Common::UString instead of std::string , so you either need to write a custom readline() that reads into a std::string, or change the code to use Common::UString directly. You would need to rewrite lots of your function to use iterators instead of indices, though. And possibly add some required methods to Common::UString()?
 Which right now allocates memory in 32 byte blocks. I should probably change that so that it doubles it capacity each time, to amortize the costs for copying
Oh wow! Life has really gotten in the way, I'd mostly forgotten about this! Sorry for completely dropping off the planet. I'm interested in working on it again, absolutely. Let me take a look at where I left off....wow, almost three years ago! And see what remains to be done. Alex…
On Tue, May 15, 2018 at 2:39 PM, Sven Hesse ***@***.***> wrote: Hej, just wanted to check in. Will you still work on this? :) If you don't have time, don't want to work on this anymore, or anything, it's of course completely fine. If there is anything I can help you with, hit me up, either here, per email or IRC. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGxhG_lmNegny-J62EKwBRVA_CRaMxbhks5ty0segaJpZM4FPdaF> .
For some reason, the history of this PR/branch is really weird. 8edb21d is really huge? These two commits are a mess, to be honest.
Can you fix this? Alternatively, can you start from scratch with an up-to-date checkout from the current master branch and rebuild your changes on top?
There's also a lot of style things still wrong, and all source code filenames should be lowercase.
Please have a look through the Developer Central page on our wiki, especially the Code Formatting Conventions. If in doubt, look at how the existing code handles things. If still in doubt, always feel free to ask me; poke me here, on IRC or by mail. :)