Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upKEYBIF: Add initial keybif tool #27
Conversation
Nostritius
force-pushed the
Nostritius:tools_keybif
branch
from
247d644
to
c51f612
Oct 20, 2018
This comment has been minimized.
This comment has been minimized.
|
ASan throws in the BIFWriter and BZFWriter tests: |
Nostritius
force-pushed the
Nostritius:tools_keybif
branch
from
c51f612
to
b73cce7
Nov 5, 2018
Nostritius
added some commits
Oct 14, 2018
Nostritius
force-pushed the
Nostritius:tools_keybif
branch
from
b73cce7
to
3115288
Nov 5, 2018
This comment has been minimized.
This comment has been minimized.
|
The Memory leaks should now be fixed |
src/common/lzma.cpp
Outdated
| @@ -130,4 +131,67 @@ SeekableReadStream *decompressLZMA1(ReadStream &input, size_t inputSize, size_t | ||
| return new MemoryReadStream(outputData, outputSize, true); | ||
| } | ||
| SeekableReadStream * compressLZMA1(ReadStream &input, size_t inputSize, size_t &outputSize) { |
This comment has been minimized.
This comment has been minimized.
DrMcCoy
Nov 11, 2018
Member
SeekableReadStream *compressLZMA1
And we don't really need that &outputSize parameter, do we? The returned stream already knows its size.
src/keybif.cpp
Outdated
| }; | ||
| bool parseCommandLine(const std::vector<Common::UString> &argv, int &returnValue, | ||
| Common::UString &keyfile, std::set<Common::UString> &files); |
This comment has been minimized.
This comment has been minimized.
src/keybif.cpp
Outdated
| } | ||
| bool parseCommandLine(const std::vector<Common::UString> &argv, int &returnValue, | ||
| Common::UString &keyfile, std::set<Common::UString> &files) { |
This comment has been minimized.
This comment has been minimized.
| Parser parser(argv[0], "BioWare KEY/BIF archive packer", | ||
| "", | ||
| returnValue, | ||
| makeEndArgs(&archiveOpt, &filesOpt)); |
This comment has been minimized.
This comment has been minimized.
man/keybif.1
Outdated
| .Sh DESCRIPTION | ||
| .Nm | ||
| packs files together into a BioWare KEY/BIF archive, found in many | ||
| BioWare Games as files with the extensions .key, .bif and .bzf where .bzf is |
This comment has been minimized.
This comment has been minimized.
man/keybif.1
Outdated
| .It Ar keyfile | ||
| The .key file to create | ||
| .It Ar files | ||
| One or more files to pack together. When a .bif/.bzf file is occurs, the following |
This comment has been minimized.
This comment has been minimized.
Nostritius
force-pushed the
Nostritius:tools_keybif
branch
from
3115288
to
417650b
Nov 12, 2018
This comment has been minimized.
This comment has been minimized.
|
The issues should now be fixed |
This comment has been minimized.
This comment has been minimized.
|
Please fix this warning too: https://travis-ci.org/xoreos/xoreos-tools/jobs/453918651#L2841 |
Nostritius
added some commits
Oct 14, 2018
This comment has been minimized.
This comment has been minimized.
|
The warning should now be fixed |
Nostritius
force-pushed the
Nostritius:tools_keybif
branch
from
417650b
to
6a824bf
Nov 13, 2018
This comment has been minimized.
This comment has been minimized.
|
Merged as 2ba8961...1ff924f, thanks! :) |
DrMcCoy
closed this
Nov 13, 2018
Nostritius
deleted the
Nostritius:tools_keybif
branch
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Nostritius commentedOct 14, 2018
This PR adds a new tool to create a key/bif archive structure, also with support for bzf files.