KEYBIF: Add initial keybif tool #27
Closed
Conversation
ASan throws in the BIFWriter and BZFWriter tests:
|
The Memory leaks should now be fixed |
src/common/lzma.cpp
Outdated
@@ -130,4 +131,67 @@ SeekableReadStream *decompressLZMA1(ReadStream &input, size_t inputSize, size_t | |||
return new MemoryReadStream(outputData, outputSize, true); | |||
} | |||
|
|||
SeekableReadStream * compressLZMA1(ReadStream &input, size_t inputSize, size_t &outputSize) { |
DrMcCoy
Nov 11, 2018
Member
SeekableReadStream *compressLZMA1
And we don't really need that &outputSize parameter, do we? The returned stream already knows its size.
SeekableReadStream *compressLZMA1
And we don't really need that &outputSize parameter, do we? The returned stream already knows its size.
src/keybif.cpp
Outdated
}; | ||
|
||
bool parseCommandLine(const std::vector<Common::UString> &argv, int &returnValue, | ||
Common::UString &keyfile, std::set<Common::UString> &files); |
DrMcCoy
Nov 11, 2018
Member
Broken alignment
Broken alignment
src/keybif.cpp
Outdated
} | ||
|
||
bool parseCommandLine(const std::vector<Common::UString> &argv, int &returnValue, | ||
Common::UString &keyfile, std::set<Common::UString> &files) { |
DrMcCoy
Nov 11, 2018
Member
Broken alignment
Broken alignment
Parser parser(argv[0], "BioWare KEY/BIF archive packer", | ||
"", | ||
returnValue, | ||
makeEndArgs(&archiveOpt, &filesOpt)); |
DrMcCoy
Nov 11, 2018
Member
Broken alignment
Broken alignment
man/keybif.1
Outdated
.Sh DESCRIPTION | ||
.Nm | ||
packs files together into a BioWare KEY/BIF archive, found in many | ||
BioWare Games as files with the extensions .key, .bif and .bzf where .bzf is |
DrMcCoy
Nov 11, 2018
Member
Comma before the "where"
Comma before the "where"
man/keybif.1
Outdated
.It Ar keyfile | ||
The .key file to create | ||
.It Ar files | ||
One or more files to pack together. When a .bif/.bzf file is occurs, the following |
DrMcCoy
Nov 11, 2018
Member
"is occurs"?
"is occurs"?
The issues should now be fixed |
Please fix this warning too: https://travis-ci.org/xoreos/xoreos-tools/jobs/453918651#L2841 |
The warning should now be fixed |
Merged as 2ba8961...1ff924f, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR adds a new tool to create a key/bif archive structure, also with support for bzf files.