New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JADE: Play background music on main menu #272

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dressupgeekout
Contributor

dressupgeekout commented May 28, 2018

I mean, it works, I dunno :}

@DrMcCoy

This comment has been minimized.

Member

DrMcCoy commented May 28, 2018

Hmm, could you rather save that ChannelHandle and use SoundMan.stopChannel()? Put this into their own methods, playMenuMusic() and stopMenuMusic() too, please.

I.e. similar to how KotOR does it: https://github.com/xoreos/xoreos/blob/master/src/engines/kotor/game.cpp#L105

@dressupgeekout

This comment has been minimized.

Contributor

dressupgeekout commented May 28, 2018

Oh heh that's definitely cleaner.

@dressupgeekout

This comment has been minimized.

Contributor

dressupgeekout commented May 28, 2018

OK let's try this. I decided that Jade::Game::playMenuMusic() shouldn't accept a parameter to let the caller decide which menu music to play, because, unlike KOTOR, there's only one menu music (even during character creation and stuff like that)

@DrMcCoy

Yup, in principle what I imagined, but two minor style issue. Please fix :)

@@ -100,6 +102,17 @@ void Game::runModule() {
_module->clear();
}
void Game::playMenuMusic()
{

This comment has been minimized.

@DrMcCoy

DrMcCoy May 28, 2018

Member

That opening brace needs to go into the previous line, please.

}
void Game::stopMenuMusic()
{

This comment has been minimized.

@DrMcCoy

DrMcCoy May 28, 2018

Member

Here too

@dressupgeekout

This comment has been minimized.

Contributor

dressupgeekout commented May 28, 2018

OK, here we go

@DrMcCoy

This comment has been minimized.

Member

DrMcCoy commented May 28, 2018

Merged as b9555a1, thanks! :)

@DrMcCoy DrMcCoy closed this May 28, 2018

@dressupgeekout dressupgeekout deleted the dressupgeekout:jade_music branch May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment