Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JADE: Play background music on main menu #272

Closed
wants to merge 1 commit into from

Conversation

@dressupgeekout
Copy link
Contributor

@dressupgeekout dressupgeekout commented May 28, 2018

I mean, it works, I dunno :}

@DrMcCoy
Copy link
Member

@DrMcCoy DrMcCoy commented May 28, 2018

Hmm, could you rather save that ChannelHandle and use SoundMan.stopChannel()? Put this into their own methods, playMenuMusic() and stopMenuMusic() too, please.

I.e. similar to how KotOR does it: https://github.com/xoreos/xoreos/blob/master/src/engines/kotor/game.cpp#L105

@dressupgeekout
Copy link
Contributor Author

@dressupgeekout dressupgeekout commented May 28, 2018

Oh heh that's definitely cleaner.

@dressupgeekout dressupgeekout force-pushed the dressupgeekout:jade_music branch from ecb94fa to f7696c0 May 28, 2018
@dressupgeekout
Copy link
Contributor Author

@dressupgeekout dressupgeekout commented May 28, 2018

OK let's try this. I decided that Jade::Game::playMenuMusic() shouldn't accept a parameter to let the caller decide which menu music to play, because, unlike KOTOR, there's only one menu music (even during character creation and stuff like that)

Copy link
Member

@DrMcCoy DrMcCoy left a comment

Yup, in principle what I imagined, but two minor style issue. Please fix :)

@@ -100,6 +102,17 @@ void Game::runModule() {
_module->clear();
}

void Game::playMenuMusic()
{

This comment has been minimized.

@DrMcCoy

DrMcCoy May 28, 2018
Member

That opening brace needs to go into the previous line, please.

}

void Game::stopMenuMusic()
{

This comment has been minimized.

@DrMcCoy

DrMcCoy May 28, 2018
Member

Here too

@dressupgeekout dressupgeekout force-pushed the dressupgeekout:jade_music branch from f7696c0 to 435627e May 28, 2018
@dressupgeekout
Copy link
Contributor Author

@dressupgeekout dressupgeekout commented May 28, 2018

OK, here we go

@DrMcCoy
Copy link
Member

@DrMcCoy DrMcCoy commented May 28, 2018

Merged as b9555a1, thanks! :)

@DrMcCoy DrMcCoy closed this May 28, 2018
@dressupgeekout dressupgeekout deleted the dressupgeekout:jade_music branch May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants