JADE: Play background music on main menu

[dressupgeekout]

I mean, it works, I dunno :}

[DrMcCoy]

Hmm, could you rather save that ChannelHandle and use SoundMan.stopChannel()? Put this into their own methods, playMenuMusic() and stopMenuMusic() too, please.

I.e. similar to how KotOR does it: https://github.com/xoreos/xoreos/blob/master/src/engines/kotor/game.cpp#L105

[dressupgeekout]

Oh heh that's definitely cleaner.

[dressupgeekout]

OK let's try this. I decided that Jade::Game::playMenuMusic() shouldn't accept a parameter to let the caller decide which menu music to play, because, unlike KOTOR, there's only one menu music (even during character creation and stuff like that)

[DrMcCoy]

Yup, in principle what I imagined, but two minor style issue. Please fix :)

[DrMcCoy]

That opening brace needs to go into the previous line, please.

[DrMcCoy]

Here too

[dressupgeekout]

OK, here we go

[DrMcCoy]

Merged as b9555a1, thanks! :)