JADE: Actually quit when "EXIT" is selected in main menu #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrMcCoy
requested changes
May 29, 2018
src/engines/jade/gui/main/main.cpp
Outdated
| @@ -125,6 +127,9 @@ void MainMenu::callbackActive(Widget &widget) { | |||
| playVideo("creditmovie"); | |||
| return; | |||
| } | |||
|
|
|||
| if (widget.getTag() == "EXIT") | |||
| EventMan.requestQuit(); | |||
There was a problem hiding this comment.
Please, indent with tabs. Tabs for indentation, spaces for alignment.
It helps if you set your editor/IDE to show tabs and/or spaces. This is how it looks in my vim setup:
There was a problem hiding this comment.
Derp I usually pay attention to that sort of thing >.<
dressupgeekout
force-pushed
the
jade_gui_exit
branch
from
7a232dc
to
c7bfab5
Compare
|
Merged, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.