New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JADE: Actually quit when "EXIT" is selected in main menu #277

Merged
merged 1 commit into from May 30, 2018

Conversation

Projects
None yet
2 participants
@dressupgeekout
Contributor

dressupgeekout commented May 28, 2018

No description provided.

@@ -125,6 +127,9 @@ void MainMenu::callbackActive(Widget &widget) {
playVideo("creditmovie");
return;
}
if (widget.getTag() == "EXIT")
EventMan.requestQuit();

This comment has been minimized.

@DrMcCoy

DrMcCoy May 29, 2018

Member

Please, indent with tabs. Tabs for indentation, spaces for alignment.

It helps if you set your editor/IDE to show tabs and/or spaces. This is how it looks in my vim setup:
tabs

This comment has been minimized.

@dressupgeekout

dressupgeekout May 29, 2018

Contributor

Derp I usually pay attention to that sort of thing >.<

@DrMcCoy DrMcCoy merged commit c7bfab5 into xoreos:master May 30, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@DrMcCoy

This comment has been minimized.

Member

DrMcCoy commented May 30, 2018

Merged, thanks! :)

@dressupgeekout dressupgeekout deleted the dressupgeekout:jade_gui_exit branch May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment