Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update documentation about different behavior between r10k and g10k #78

Closed
riton opened this issue Oct 13, 2017 · 2 comments
Closed

Comments

@riton
Copy link

riton commented Oct 13, 2017

First of all, thanks !
I was planning to implement something like r10k in GoLang and then I found your project. Big kudos to you !

Then I've tried to use g10k on the Puppetfile we're using and I hit bug #2 .
I had to dig into the code to really understand why it was mis-interpreting (differently as r10k) our git based modules as forge modules. And then I found the bug.

Can you please update the documentation and mention that this behavior is different than r10k one ? This could save next person some time :-)

Note : maybe that #2 can be closed if you do not plan to support it at all ?

Thanks !

@blackknight36
Copy link

I second this. g10k claims to be a drop-in replacement for r10k but in truth it requires changes to your puppetfile to work properly.

@xorpaul
Copy link
Owner

xorpaul commented Oct 18, 2017

Removed any mention of drop-in replacement from readme

@xorpaul xorpaul closed this as completed Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants