Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to disable Dialog action buttons. Updated Dialog docs. #316

merged 9 commits into from Mar 20, 2018


Copy link

@ShayanJavadi ShayanJavadi commented Mar 16, 2018

I added the option to disable Dialog buttons. This is specially useful for handling "Affirmative Actions" as noted here in the Material Design guidelines (scroll down to where it says "Languages without capitalization" and you can see what I'm referring to under the picture with Korean in it)

So for example if you had an action called "cancel" and wanted to disable it you would do:

   actions={['cancel', 'ok']}
   * this will disable the button for "cancel"
   options={{ cancel: { disabled: true } }}
   onActionPress={() => {}}

I also updated the docs for Dialog to reflect the changes.

My changes are reflected in both the stacked and default actions.

Let me know if you have any comments or questions!

here's screenshots of it in action:
screen shot 2018-03-16 at 12 01 07 am
screen shot 2018-03-16 at 12 01 11 am
screen shot 2018-03-16 at 12 00 31 am
screen shot 2018-03-16 at 12 00 40 am

@ShayanJavadi ShayanJavadi changed the title Added options to disable Dialog action buttons. Updated Dialog docs. Added option to disable Dialog action buttons. Updated Dialog docs. Mar 16, 2018
Copy link

@codecov-io codecov-io commented Mar 16, 2018

Codecov Report

Merging #316 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #316   +/-   ##
  Coverage   76.64%   76.64%           
  Files          19       19           
  Lines         775      775           
  Branches      114      114           
  Hits          594      594           
  Misses        150      150           
  Partials       31       31
Copy link
Contributor Author

@ShayanJavadi ShayanJavadi commented Mar 19, 2018

Hey @xotahal did you get a chance to review this pr yet?

@janziemba janziemba self-requested a review Mar 20, 2018
@janziemba janziemba self-assigned this Mar 20, 2018
Copy link

@janziemba janziemba commented Mar 20, 2018

Approved. Thank you.

@janziemba janziemba merged commit f55332d into xotahal:master Mar 20, 2018
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
codecov/patch Coverage not affected when comparing 8a05941...33d655d
codecov/project 76.64% remains the same compared to 8a05941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants