New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to disable Dialog action buttons. Updated Dialog docs. #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
=======================================
Coverage 76.64% 76.64%
=======================================
Files 19 19
Lines 775 775
Branches 114 114
=======================================
Hits 594 594
Misses 150 150
Partials 31 31 |
Hey @xotahal did you get a chance to review this pr yet? |
janziemba
approved these changes
Mar 20, 2018
Approved. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I added the option to disable Dialog buttons. This is specially useful for handling "Affirmative Actions" as noted here in the Material Design guidelines (scroll down to where it says "Languages without capitalization" and you can see what I'm referring to under the picture with Korean in it)
So for example if you had an action called "cancel" and wanted to disable it you would do:
I also updated the docs for Dialog to reflect the changes.
My changes are reflected in both the stacked and default actions.
Let me know if you have any comments or questions!
here's screenshots of it in action:



