Prepend iconsDark path after setting default path. #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the "dark theme" option is set, the iconsDark directory should be the first dir where the icon theme should search for the icon. By prepending this path after the default icons path has been set, we make sure that this dir is indeed the first in the list of dirs to look up icons. Fixes issue #1746.
|
LGTM, thanks for the PR. |
Technius
added a commit
to Technius/xournalpp
that referenced
this pull request
Apr 12, 2020
Prepend iconsDark path after setting default path. Backport: 9df451a
Technius
added a commit
that referenced
this pull request
Apr 15, 2020
Prepend iconsDark path after setting default path. Backport: 9df451a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "dark theme" option is set, the iconsDark directory should be
the first dir where the icon theme should search for the icon. By
prepending this path after the default icons path has been set, we make
sure that this dir is indeed the first in the list of dirs to look up
icons.
Fixes issue #1746.