New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CacheHandler::isValid() 에서 $modified_time 기본값이 없는 문제 수정 #2205

Merged
merged 1 commit into from Jan 9, 2018

Conversation

2 participants
@kijin
Contributor

kijin commented Jan 9, 2018

CacheBase를 포함한 실제 캐시 클래스는 모두 isValid() 메소드에 $modified_time = 0 으로 기본값이 지정되어 있는데, CacheHandler 클래스에만 기본값이 없습니다.

이것 때문에 일부 서드파티 자료를 PHP 7.1에서 실행하면 Too few arguments to function CacheHandler::isValid(), 1 passed ... and exactly 2 expected 라는 에러가 발생하고 있습니다. 개발자 입장에서도 두 번째 인자가 필요한지 안 필요한지 헷갈리니까요.

일관성있는 기본값을 지정하여 에러를 방지합니다.

@bnu bnu self-assigned this Jan 9, 2018

@bnu bnu added the type/bug label Jan 9, 2018

@bnu bnu added this to the 1.9-2018-02W milestone Jan 9, 2018

@bnu bnu merged commit 602a167 into xpressengine:develop Jan 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bnu bnu added this to 이슈 종료 in 이슈 진행 상황 via automation Jan 9, 2018

@kijin kijin deleted the kijin:fix/cacheHandler-isValid branch Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment