New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attributes on p:directory-list #436

Closed
xml-project opened this Issue Jul 2, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@xml-project
Contributor

xml-project commented Jul 2, 2018

I suggest to change the type attribute of @include-filter and @exclude-filter from "xs:string" to "xs:string+", so one can use a sequence of regular expressions to filter results.

Semantics: An item is included, if it matches (at least) one of the include-filters and none of the exclude-filters.

@ndw

This comment has been minimized.

Contributor

ndw commented Jul 2, 2018

How do space-separated regular expressions interact with users who put spaces in filenames?

@xml-project

This comment has been minimized.

Contributor

xml-project commented Jul 2, 2018

@ndw I do not suggest a space-separated regex, but "xs:string+" = ("regex1", "regex2 ....)

@ndw

This comment has been minimized.

Contributor

ndw commented Jul 2, 2018

Hmm. Isn't that going to be a bit awkward? This will work:

 include-filter="*.txt"

but if you step up to multiple values, you'll have to do this:

 include-filter="{('*.txt', '*.tx')}"

I guess I can live with that, but ...

@xml-project

This comment has been minimized.

Contributor

xml-project commented Jul 2, 2018

You do not have to use it, but I think we should give it a try because it makes regular expression easier to write (and debug).

@ndw

This comment has been minimized.

Contributor

ndw commented Jul 2, 2018

Okay.

@ndw

This comment has been minimized.

Contributor

ndw commented Sep 5, 2018

We did this.

@ndw ndw closed this Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment