New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think err:XS0044 is doing too much work #556

Closed
ndw opened this Issue Oct 11, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@ndw
Contributor

ndw commented Oct 11, 2018

At the moment, almost any syntactic error raises XS0044. In particular, an element that occurs where it isn't allowed and a non-whitespace text node that appears where it isn't allowed both raise this error.

I propose that we create a new error for "text isn't allowed here". That's really quite different from "this element isn't allowed here".

@xml-project

This comment has been minimized.

Contributor

xml-project commented Oct 12, 2018

Have a look at XS0037:

It is a static error (err:XS0037) if any user extension step or any element in the XProc namespace other than p:inline directly contains text nodes that do not consist entirely of whitespace.

I think that would do the work in most cases, but I am definitely in favor of more specific static errors which is in my view a big advantage for developers.

@ndw

This comment has been minimized.

Contributor

ndw commented Oct 12, 2018

Perfect. In that case, there are a couple of tests I want to change :-)

@ndw ndw closed this Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment