New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are all input ports connected automatically, or only primary ones? #685

Closed
ndw opened this Issue Jan 3, 2019 · 7 comments

Comments

Projects
None yet
3 participants
@ndw
Contributor

ndw commented Jan 3, 2019

§5 says the primary input ports are special because they'll be automatically connected to the default readable port. I have this vague recollection that we decided all inputs should be automatically connected to the default readable port, even secondary ones. Is the spec wrong, or is my recollection faulty?

@xml-project

This comment has been minimized.

Contributor

xml-project commented Jan 3, 2019

I remember we discussed this ones, but we did not follow it along. If I remember right, I found the rules to confusing. So the specs are right and your recollection is almost right.

@xml-project

This comment has been minimized.

Contributor

xml-project commented Jan 3, 2019

Locking up my notes from Prague last year, I found a request of auto-connection non primary ports not to DRP, but connecting input port with number 'n' to the output port number 'n' of the previous step. I think it came from the DAISY people.
I think we p:with-input pipe="port" we found a better solution.

@gimsieke

This comment has been minimized.

Contributor

gimsieke commented Jan 4, 2019

I searched old issues and notes in the Wikis.

It seems as if in #447, we rejected the idea that non-primary input ports will connect to the DRP.

The discussion in #446 might also be relevant.


Other possibly relevant issues that I found:

In #544, @xml-project proposed the rule (not reflected in the spec yet)

that a step that has an input port that's unbound, if there is no default readable port, will use the declared default for that port.

This implies that he thought that any step without a declared default will read its input from the DRP. This would have to be reworded in the light of the #447 decision.


In this commtent, I stated the assumption that secondary inputs will not read the DRP if there is no explicit or default connection. This assumption was not further discussed.

@xml-project

This comment has been minimized.

Contributor

xml-project commented Jan 4, 2019

@gimsieke I am afraid you quoted me wrong: The case we discussed was a default binding on a primary input port. So it was not implied,

that any step without a declared default will read its input from the DRP.

@gimsieke

This comment has been minimized.

Contributor

gimsieke commented Jan 4, 2019

I quoted your exact words. Maybe you can clarify this by giving a complete paragraph that would replace

A default connection does not satisfy […] if no external connection is provided for the port.

at the end of p:with-input.

Or maybe it should just be removed there, and we can augment the paragraph 3 paras above that currently reads:

An input declaration may include a default connection. If no connection is provided for an input port which has a default connection, then the input is treated as if the default connection appeared.

like this:

An input declaration may include a default connection. If no connection is provided for an input port which has a default connection, then the input is treated as if the default connection appeared. For primary input ports, the default readable port (if present) provides a connection. If there is a default readable port, a primary input for which a default connection is declared will therefore not use its default connection.

@xml-project

This comment has been minimized.

Contributor

xml-project commented Jan 4, 2019

I quoted your exact words.

Context is important, even with quotes. ;-))

@ndw

This comment has been minimized.

Contributor

ndw commented Jan 4, 2019

Executive summary: the spec is correct and my recollection is...hazy. Only the primary input port is automatically connected to the DRP.

@ndw ndw closed this Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment