New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the p:inline exception for [p:]use-when? #694

Closed
ndw opened this Issue Jan 6, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@ndw
Contributor

ndw commented Jan 6, 2019

I propose that we remove this paragraph:

<para>Exception: <tag class="attribute">[p:]use-when</tag> attributes
on descendant <tag>p:inline</tag> elements and in implicit inlines
carry no special meaning and are considered part of the inlined
contents.</para>
  1. It makes the spec more complicated
  2. It strikes me as very unlikely in the real world
  3. A pipeline that wanted to create a pipeline containing use-when attributes using p:inline
    (see what I mean about unlikely?) could use x:use-when attributes in the inline and
    rename them in a subsequent step.
@ndw

This comment has been minimized.

Contributor

ndw commented Jan 8, 2019

This is easy to do. Anyone object?

@eriksiegel

This comment has been minimized.

Contributor

eriksiegel commented Jan 8, 2019

So what you mean is to have @[p:]use-when in p:inline-d content processed as normal @[p:]use-when? I'm fine with that.

@xml-project

This comment has been minimized.

Contributor

xml-project commented Jan 8, 2019

I have no special opinion on this. Of course @ndw is right that it make things in the specs a lot easier, but I am not sure that people synthesising pipelines would agree. So I would leave this to @gimsieke

@gimsieke

This comment has been minimized.

Contributor

gimsieke commented Jan 8, 2019

No objection. We can use the workaround that @ndw sketched if we need to.

@ndw ndw self-assigned this Jan 8, 2019

@ndw ndw closed this in #701 Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment