Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: make the error port the default readable port in p:catch/p:finally #847

Closed
ndw opened this issue Jul 22, 2019 · 2 comments

Comments

@ndw
Copy link
Contributor

commented Jul 22, 2019

Observations (unless I’ve overlooked something, of course):

  1. If you want to read the error port in a p:catch, you have to both name the catch and fully qualify the p:pipe (or @pipe) that reads from it.
...
<p:catch name=“catch”>
   <p:identity>
      <p:with-input pipe=“error@catch”/>
   </p:identity>
...
  1. The default readable port, if there is one, comes from the step that precedes the p:try. That doesn’t seem like a very useful default.
  2. Authors can always write pipes that point back to the preceding step if they want. And that will probably feel (relatively) natural as they’re reaching outside the confines of the container that they’re in.

It’s a little odd, I admit, but I still think it might be an improvement.

@ndw

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

I guess this proposal also proposes that the error port should be primary in p:catch though I suppose that’s not strictly necessary.

@xml-project

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

👍 If I remember right, we talked about this on one of our face to face meetings, but we have never put it into the specs.

@ndw ndw self-assigned this Jul 22, 2019

@ndw ndw closed this in f5c4421 Jul 22, 2019

ndw added a commit that referenced this issue Jul 22, 2019

Merge pull request #848 from ndw/iss-847
Fix #847 by making the error port primary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.